drm: make various debugfs_init() functions return 0 (e196e140) · Commits · 戴 / test

Since commit (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of various debugfs_init() functions in drm, and have these functions return 0 directly. v2: convert debugfs_init() functions to return 0 instead of void to avoid build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by:

Wambui Karuga <wambui.karugax@gmail.com> Reviewed-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:

Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-16-wambui.karugax@gmail.com

drivers/gpu/drm/drm_atomic.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1643,8 +1643,9 @@ static const struct drm_info_list drm_atomic_debugfs_list[] = {

		int drm_atomic_debugfs_init(struct drm_minor *minor)
		{
		return drm_debugfs_create_files(drm_atomic_debugfs_list,
		drm_debugfs_create_files(drm_atomic_debugfs_list,
		ARRAY_SIZE(drm_atomic_debugfs_list),
		minor->debugfs_root, minor);
		return 0;
		}
		#endif

drivers/gpu/drm/drm_client.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -459,8 +459,10 @@ static const struct drm_info_list drm_client_debugfs_list[] = {

		int drm_client_debugfs_init(struct drm_minor *minor)
		{
		return drm_debugfs_create_files(drm_client_debugfs_list,
		drm_debugfs_create_files(drm_client_debugfs_list,
		ARRAY_SIZE(drm_client_debugfs_list),
		minor->debugfs_root, minor);

		return 0;
		}
		#endif

drivers/gpu/drm/drm_framebuffer.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -1209,8 +1209,10 @@ static const struct drm_info_list drm_framebuffer_debugfs_list[] = {

		int drm_framebuffer_debugfs_init(struct drm_minor *minor)
		{
		return drm_debugfs_create_files(drm_framebuffer_debugfs_list,
		drm_debugfs_create_files(drm_framebuffer_debugfs_list,
		ARRAY_SIZE(drm_framebuffer_debugfs_list),
		minor->debugfs_root, minor);

		return 0;
		}
		#endif

Admin message