Unverified Commit e191a082 authored Jun 18, 2020 by Douglas Anderson Committed by Mark Brown Jun 19, 2020

spi: spi-geni-qcom: Check for error IRQs



>From reading the #defines it seems like we should shout if we ever see
one of these error bits.  Let's do so.  This doesn't do anything
functional except print a yell in the log if the error bits are seen.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20200618080459.v4.3.Id8bebdbdb4d2ed9468634343a7e6207d6cffff8a@changeid


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 2ee471a1

drivers/spi/spi-geni-qcom.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -506,6 +506,11 @@ static irqreturn_t geni_spi_isr(int irq, void *data)
		if (!m_irq)
		return IRQ_NONE;

		if (m_irq & (M_CMD_OVERRUN_EN \| M_ILLEGAL_CMD_EN \| M_CMD_FAILURE_EN \|
		M_RX_FIFO_RD_ERR_EN \| M_RX_FIFO_WR_ERR_EN \|
		M_TX_FIFO_RD_ERR_EN \| M_TX_FIFO_WR_ERR_EN))
		dev_warn(mas->dev, "Unexpected IRQ err status %#010x\n", m_irq);

		spin_lock(&mas->lock);

		if ((m_irq & M_RX_FIFO_WATERMARK_EN) \|\| (m_irq & M_RX_FIFO_LAST_EN))

Admin message