Commit e17a7c0e authored Aug 19, 2020 by Frederic Barrat Committed by Michael Ellerman Aug 20, 2020

powerpc/powernv/pci: Fix possible crash when releasing DMA resources



Fix a typo introduced during recent code cleanup, which could lead to
silently not freeing resources or an oops message (on PCI hotplug or
CAPI reset).

Only impacts ioda2, the code path for ioda1 is correct.

Fixes: 01e12629 ("powerpc/powernv/pci: Add explicit tracking of the DMA setup state")
Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>
Reviewed-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200819130741.16769-1-fbarrat@linux.ibm.com

parent 801980f6

arch/powerpc/platforms/powernv/pci-ioda.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2705,7 +2705,7 @@ void pnv_pci_ioda2_release_pe_dma(struct pnv_ioda_pe *pe)
		struct iommu_table *tbl = pe->table_group.tables[0];
		int64_t rc;

		if (pe->dma_setup_done)
		if (!pe->dma_setup_done)
		return;

		rc = pnv_pci_ioda2_unset_window(&pe->table_group, 0);

Admin message