Commit e1781538 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar
Browse files

sched: Assert task state bits at build time 



Since everybody is lazy and prone to forgetting things, make the
compiler help us a bit.

Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20091217121830.060186433@chello.nl>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 464763cf

fs/proc/array.c

+10 −8
Original line number Diff line number Diff line
@@ -151,6 +151,8 @@ static inline const char *get_task_state(struct task_struct *tsk) 
	unsigned int state = (tsk->state & TASK_REPORT) | tsk->exit_state;

	const char **p = &task_state_array[0];



	BUILD_BUG_ON(1 + ilog2(TASK_STATE_MAX) != ARRAY_SIZE(task_state_array));



	while (state) {

		p++;

		state >>= 1;

include/linux/sched.h

+4 −0
Original line number Diff line number Diff line
@@ -192,9 +192,13 @@ print_cfs_rq(struct seq_file *m, int cpu, struct cfs_rq *cfs_rq) 
#define TASK_DEAD		64

#define TASK_WAKEKILL		128

#define TASK_WAKING		256

#define TASK_STATE_MAX		512



#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKW"



extern char ___assert_task_state[1 - 2*!!(

		sizeof(TASK_STATE_TO_CHAR_STR)-1 != ilog2(TASK_STATE_MAX)+1)];



/* Convenience macros for the sake of set_task_state */

#define TASK_KILLABLE		(TASK_WAKEKILL | TASK_UNINTERRUPTIBLE)

#define TASK_STOPPED		(TASK_WAKEKILL | __TASK_STOPPED)

CRA Git | Maintained and supported by SUSTech CRA and CCSE