Commit e1746e83 authored Dec 01, 2015 by Zhao Lei Committed by Chris Mason Jan 20, 2016

btrfs: Fix no_space in write and rm loop



I see no_space in v4.4-rc1 again in xfstests generic/102.
It happened randomly in some node only.
(one of 4 phy-node, and a kvm with non-virtio block driver)

By bisect, we can found the first-bad is:
 commit bdced438 ("block: setup bi_phys_segments after splitting")'
But above patch only triggered the bug by making bio operation
faster(or slower).

Main reason is in our space_allocating code, we need to commit
page writeback before wait it complish, this patch fixed above
bug.

BTW, there is another reason for generic/102 fail, caused by
disable default mixed-blockgroup, I'll fix it in xfstests.

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Chris Mason <clm@fb.com>

parent 0bc19f90

fs/btrfs/extent-tree.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -4139,8 +4139,10 @@ commit_trans:
		!atomic_read(&root->fs_info->open_ioctl_trans)) {
		need_commit--;

		if (need_commit > 0)
		if (need_commit > 0) {
		btrfs_start_delalloc_roots(fs_info, 0, -1);
		btrfs_wait_ordered_roots(fs_info, -1);
		}

		trans = btrfs_join_transaction(root);
		if (IS_ERR(trans))

Admin message