Commit e172662d authored Dec 02, 2010 by Wu Fengguang Committed by Linus Torvalds Dec 02, 2010

vmstat: fix dirty threshold ordering



The nr_dirty_[background_]threshold fields are misplaced before the
numa_* fields, and users will read strange values.

This is the right order.  Before patch, nr_dirty_background_threshold
will read as 0 (the value from numa_miss).

	numa_hit 128501
	numa_miss 0
	numa_foreign 0
	numa_interleave 7388
	numa_local 128501
	numa_other 0
	nr_dirty_threshold 144291
	nr_dirty_background_threshold 72145

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Cc: Michael Rubin <mrubin@google.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 55cfaa3c

mm/vmstat.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -750,8 +750,6 @@ static const char * const vmstat_text[] = {
		"nr_shmem",
		"nr_dirtied",
		"nr_written",
		"nr_dirty_threshold",
		"nr_dirty_background_threshold",

		#ifdef CONFIG_NUMA
		"numa_hit",
		@@ -761,6 +759,8 @@ static const char * const vmstat_text[] = {
		"numa_local",
		"numa_other",
		#endif
		"nr_dirty_threshold",
		"nr_dirty_background_threshold",

		#ifdef CONFIG_VM_EVENT_COUNTERS
		"pgpgin",

Admin message