Commit e159489b authored by Tejun Heo's avatar Tejun Heo
Browse files

workqueue: relax lockdep annotation on flush_work() 



Currently, the lockdep annotation in flush_work() requires exclusive
access on the workqueue the target work is queued on and triggers
warning if a work is trying to flush another work on the same
workqueue; however, this is no longer true as workqueues can now
execute multiple works concurrently.

This patch adds lock_map_acquire_read() and make process_one_work()
hold read access to the workqueue while executing a work and
start_flush_work() check for write access if concurrnecy level is one
or the workqueue has a rescuer (as only one execution resource - the
rescuer - is guaranteed to be available under memory pressure), and
read access if higher.

This better represents what's going on and removes spurious lockdep
warnings which are triggered by fake dependency chain created through
flush_work().

* Peter pointed out that flushing another work from a WQ_MEM_RECLAIM
  wq breaks forward progress guarantee under memory pressure.
  Condition check accordingly updated.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Reported-by: default avatar"Rafael J. Wysocki" <rjw@sisk.pl>
Tested-by: default avatar"Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@kernel.org
parent 0c21e3aa

include/linux/lockdep.h

+3 −0
Original line number Diff line number Diff line
@@ -522,12 +522,15 @@ static inline void print_irqtrace_events(struct task_struct *curr) 
#ifdef CONFIG_DEBUG_LOCK_ALLOC

# ifdef CONFIG_PROVE_LOCKING

#  define lock_map_acquire(l)		lock_acquire(l, 0, 0, 0, 2, NULL, _THIS_IP_)

#  define lock_map_acquire_read(l)	lock_acquire(l, 0, 0, 2, 2, NULL, _THIS_IP_)

# else

#  define lock_map_acquire(l)		lock_acquire(l, 0, 0, 0, 1, NULL, _THIS_IP_)

#  define lock_map_acquire_read(l)	lock_acquire(l, 0, 0, 2, 1, NULL, _THIS_IP_)

# endif

# define lock_map_release(l)			lock_release(l, 1, _THIS_IP_)

#else

# define lock_map_acquire(l)			do { } while (0)

# define lock_map_acquire_read(l)		do { } while (0)

# define lock_map_release(l)			do { } while (0)

#endif

kernel/workqueue.c

+12 −2
Original line number Diff line number Diff line
@@ -1840,7 +1840,7 @@ __acquires(&gcwq->lock) 
	spin_unlock_irq(&gcwq->lock);



	work_clear_pending(work);

	lock_map_acquire(&cwq->wq->lockdep_map);

	lock_map_acquire_read(&cwq->wq->lockdep_map);

	lock_map_acquire(&lockdep_map);

	trace_workqueue_execute_start(work);

	f(work);
@@ -2384,8 +2384,18 @@ static bool start_flush_work(struct work_struct *work, struct wq_barrier *barr, 
	insert_wq_barrier(cwq, barr, work, worker);

	spin_unlock_irq(&gcwq->lock);



	/*

	 * If @max_active is 1 or rescuer is in use, flushing another work

	 * item on the same workqueue may lead to deadlock.  Make sure the

	 * flusher is not running on the same workqueue by verifying write

	 * access.

	 */

	if (cwq->wq->saved_max_active == 1 || cwq->wq->flags & WQ_RESCUER)

		lock_map_acquire(&cwq->wq->lockdep_map);

	else

		lock_map_acquire_read(&cwq->wq->lockdep_map);

	lock_map_release(&cwq->wq->lockdep_map);



	return true;

already_gone:

	spin_unlock_irq(&gcwq->lock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE