Commit e1427237 authored by Florian Westphal's avatar Florian Westphal Committed by David S. Miller
Browse files

macsec: add noinline tag to avoid a frame size warning 



seen with debug config:
drivers/net/macsec.c: In function 'dump_secy':
drivers/net/macsec.c:2597: warning: the frame size of 2216 bytes is larger
than 2048 bytes [-Wframe-larger-than=]

just mark it with noinline_for_stack, this is netlink dump code.

v2: use 'static noinline_for_stack int' consistently

Cc: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Reviewed-by: default avatarSabrina Dubroca <sd@queasysnail.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3dc93e85

drivers/net/macsec.c

+12 −10
Original line number Diff line number Diff line
@@ -2175,7 +2175,8 @@ static int copy_tx_sa_stats(struct sk_buff *skb, 
	return 0;

}



static int copy_rx_sa_stats(struct sk_buff *skb,

static noinline_for_stack int

copy_rx_sa_stats(struct sk_buff *skb,

		 struct macsec_rx_sa_stats __percpu *pstats)

{

	struct macsec_rx_sa_stats sum = {0, };
@@ -2201,8 +2202,8 @@ static int copy_rx_sa_stats(struct sk_buff *skb, 
	return 0;

}



static int copy_rx_sc_stats(struct sk_buff *skb,

			    struct pcpu_rx_sc_stats __percpu *pstats)

static noinline_for_stack int

copy_rx_sc_stats(struct sk_buff *skb, struct pcpu_rx_sc_stats __percpu *pstats)

{

	struct macsec_rx_sc_stats sum = {0, };

	int cpu;
@@ -2265,8 +2266,8 @@ static int copy_rx_sc_stats(struct sk_buff *skb, 
	return 0;

}



static int copy_tx_sc_stats(struct sk_buff *skb,

			    struct pcpu_tx_sc_stats __percpu *pstats)

static noinline_for_stack int

copy_tx_sc_stats(struct sk_buff *skb, struct pcpu_tx_sc_stats __percpu *pstats)

{

	struct macsec_tx_sc_stats sum = {0, };

	int cpu;
@@ -2305,8 +2306,8 @@ static int copy_tx_sc_stats(struct sk_buff *skb, 
	return 0;

}



static int copy_secy_stats(struct sk_buff *skb,

			   struct pcpu_secy_stats __percpu *pstats)

static noinline_for_stack int

copy_secy_stats(struct sk_buff *skb, struct pcpu_secy_stats __percpu *pstats)

{

	struct macsec_dev_stats sum = {0, };

	int cpu;
@@ -2410,7 +2411,8 @@ cancel: 
	return 1;

}



static int dump_secy(struct macsec_secy *secy, struct net_device *dev,

static noinline_for_stack int

dump_secy(struct macsec_secy *secy, struct net_device *dev,

	  struct sk_buff *skb, struct netlink_callback *cb)

{

	struct macsec_rx_sc *rx_sc;

CRA Git | Maintained and supported by SUSTech CRA and CCSE