rcu: Move rcu_{expedited,normal} definitions into rcupdate.h (e1350e8e) · Commits · 戴 / test

This commit moves the rcu_{expedited,normal} definitions from kernel/rcu/update.c to include/linux/rcupdate.h to make sure they are in sync, and also to avoid the following warning from sparse: kernel/ksysfs.c:150:5: warning: symbol 'rcu_expedited' was not declared. Should it be static? kernel/ksysfs.c:167:5: warning: symbol 'rcu_normal' was not declared. Should it be static? Signed-off-by:

Ben Dooks <ben.dooks@codethink.co.uk> Signed-off-by:

Paul E. McKenney <paulmck@kernel.org>

include/linux/rcupdate.h

+4 −0

Original line number	Diff line number	Diff line
		@@ -896,4 +896,8 @@ rcu_head_after_call_rcu(struct rcu_head *rhp, rcu_callback_t f)
		return false;
		}

		/* kernel/ksysfs.c definitions */
		extern int rcu_expedited;
		extern int rcu_normal;

		#endif /* __LINUX_RCUPDATE_H */

kernel/rcu/update.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -51,9 +51,7 @@
		#define MODULE_PARAM_PREFIX "rcupdate."

		#ifndef CONFIG_TINY_RCU
		extern int rcu_expedited; /* from sysctl */
		module_param(rcu_expedited, int, 0);
		extern int rcu_normal; /* from sysctl */
		module_param(rcu_normal, int, 0);
		static int rcu_normal_after_boot;
		module_param(rcu_normal_after_boot, int, 0);

Admin message