Commit e1319331 authored Nov 17, 2009 by Hidetoshi Seto Committed by Linus Torvalds Nov 17, 2009

mm/memory_hotplug: fix section mismatch



With CONFIG_MEMORY_HOTPLUG I got following warning:

WARNING: vmlinux.o(.text+0x1276b0): Section mismatch in reference from
the function hotadd_new_pgdat() to the function
.meminit.text:free_area_init_node()
The function hotadd_new_pgdat() references
the function __meminit free_area_init_node().
This is often because hotadd_new_pgdat lacks a __meminit
annotation or the annotation of free_area_init_node is wrong.

Use __ref to fix this.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 410d7a97

mm/memory_hotplug.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -447,7 +447,8 @@ int online_pages(unsigned long pfn, unsigned long nr_pages)
		}
		#endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */

		static pg_data_t *hotadd_new_pgdat(int nid, u64 start)
		/* we are OK calling __meminit stuff here - we have CONFIG_MEMORY_HOTPLUG */
		static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)
		{
		struct pglist_data *pgdat;
		unsigned long zones_size[MAX_NR_ZONES] = {0};

Admin message