xfs: handle racy AIO in xfs_reflink_end_cow (e12199f8) · Commits · 戴 / test

If we got two AIO writes into a COW area the second one might not have any COW extents left to convert. Handle that case gracefully instead of triggering an assert or accessing beyond the bounds of the extent list. Signed-off-by:

Christoph Hellwig <hch@lst.de> Reviewed-by:

Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by:

Darrick J. Wong <darrick.wong@oracle.com>

fs/xfs/xfs_reflink.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -736,7 +736,13 @@ xfs_reflink_end_cow(
		/* If there is a hole at end_fsb - 1 go to the previous extent */
		if (!xfs_iext_lookup_extent(ip, ifp, end_fsb - 1, &idx, &got) \|\|
		got.br_startoff > end_fsb) {
		ASSERT(idx > 0);
		/*
		* In case of racing, overlapping AIO writes no COW extents
		* might be left by the time I/O completes for the loser of
		* the race. In that case we are done.
		*/
		if (idx <= 0)
		goto out_cancel;
		xfs_iext_get_extent(ifp, --idx, &got);
		}

		@@ -809,6 +815,7 @@ next_extent:

		out_defer:
		xfs_defer_cancel(&dfops);
		out_cancel:
		xfs_trans_cancel(tp);
		xfs_iunlock(ip, XFS_ILOCK_EXCL);
		out:

Admin message