Commit e10c3219 authored by Carlo Caione's avatar Carlo Caione Committed by Ulf Hansson
Browse files

mmc: core: Enable tuning according to the actual timing 



While in sdhci_execute_tuning() the choice whether or not to enable the
tuning is done on the actual timing, in the mmc_sdio_init_uhs_card() the
check is done on the capability of the card.

This difference is causing some issues with some SDIO cards in DDR50
mode where the CDM19 is wrongly issued.

With this patch we modify the check in both
mmc_(sd|sdio)_init_uhs_card() functions to take the proper decision
only according to the actual timing specification.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarCarlo Caione <carlo@endlessm.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent f5abc767

drivers/mmc/core/sd.c

+4 −4
Original line number Diff line number Diff line
@@ -638,9 +638,9 @@ static int mmc_sd_init_uhs_card(struct mmc_card *card) 
	 * SDR104 mode SD-cards. Note that tuning is mandatory for SDR104.

	 */

	if (!mmc_host_is_spi(card->host) &&

		(card->sd_bus_speed == UHS_SDR50_BUS_SPEED ||

		 card->sd_bus_speed == UHS_DDR50_BUS_SPEED ||

		 card->sd_bus_speed == UHS_SDR104_BUS_SPEED)) {

		(card->host->ios.timing == MMC_TIMING_UHS_SDR50 ||

		 card->host->ios.timing == MMC_TIMING_UHS_DDR50 ||

		 card->host->ios.timing == MMC_TIMING_UHS_SDR104)) {

		err = mmc_execute_tuning(card);



		/*
@@ -650,7 +650,7 @@ static int mmc_sd_init_uhs_card(struct mmc_card *card) 
		 * difference between v3.00 and 3.01 spec means that CMD19

		 * tuning is also available for DDR50 mode.

		 */

		if (err && card->sd_bus_speed == UHS_DDR50_BUS_SPEED) {

		if (err && card->host->ios.timing == MMC_TIMING_UHS_DDR50) {

			pr_warn("%s: ddr50 tuning failed\n",

				mmc_hostname(card->host));

			err = 0;

drivers/mmc/core/sdio.c

+2 −2
Original line number Diff line number Diff line
@@ -535,8 +535,8 @@ static int mmc_sdio_init_uhs_card(struct mmc_card *card) 
	 * SDR104 mode SD-cards. Note that tuning is mandatory for SDR104.

	 */

	if (!mmc_host_is_spi(card->host) &&

	    ((card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR50) ||

	     (card->sw_caps.sd3_bus_mode & SD_MODE_UHS_SDR104)))

	    ((card->host->ios.timing == MMC_TIMING_UHS_SDR50) ||

	      (card->host->ios.timing == MMC_TIMING_UHS_SDR104)))

		err = mmc_execute_tuning(card);

out:

	return err;

CRA Git | Maintained and supported by SUSTech CRA and CCSE