Commit e10b376e authored Mar 21, 2011 by Artem Bityutskiy

UBI: make the control character device non-seekable



This patch makes the UBI control device (/dev/ubi_ctrl) non-seekable.
The seek operation does is not applicable to this file, so it is
cleaner to explicitly return error (which the added 'no_llseek()')
does than trying to change the position (which the removed
'default_llseek()' does).

This is an API break, but the only known user of this interface is
mtd-utils which does not need the seeking functionality. And any app
which relies on this is broken, but I'm not aware of such apps.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

parent a6360dd3

drivers/mtd/ubi/cdev.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1100,5 +1100,5 @@ const struct file_operations ubi_ctrl_cdev_operations = {
		.owner = THIS_MODULE,
		.unlocked_ioctl = ctrl_cdev_ioctl,
		.compat_ioctl = ctrl_cdev_compat_ioctl,
		.llseek = noop_llseek,
		.llseek = no_llseek,
		};

Admin message