Commit e108c66e authored May 16, 2012 by Jiri Olsa Committed by Arnaldo Carvalho de Melo May 22, 2012

perf tools: Carry perf_event_attr bitfield throught different endians



When the perf data file is read cross architectures, the
perf_event__attr_swap function takes care about endianness of all the
struct fields except the bitfield flags.

The bitfield flags need to be transformed as well, since the bitfield
binary storage differs for both endians.

ABI says:
  Bit-fields are allocated from right to left (least to most significant)
  on little-endian implementations and from left to right (most to least
  significant) on big-endian implementations.

The above seems to be byte specific, so we need to reverse each byte of
the bitfield. 'Internet' also says this might be implementation specific
and we probably need proper fix and carry perf_event_attr bitfield flags
in separate data file FEAT_ section. Thought this seems to work for now.

Note, running following to test perf endianity handling:
test 1)
  - origin system:
    # perf record -a -- sleep 10 (any perf record will do)
    # perf report > report.origin
    # perf archive perf.data

  - copy the perf.data, report.origin and perf.data.tar.bz2
    to a target system and run:
    # tar xjvf perf.data.tar.bz2 -C ~/.debug
    # perf report > report.target
    # diff -u report.origin report.target

  - the diff should produce no output
    (besides some white space stuff and possibly different
     date/TZ output)

test 2)
  - origin system:
    # perf record -ag -fo /tmp/perf.data -- sleep 1
  - mount origin system root to the target system on /mnt/origin
  - target system:
    # perf script --symfs /mnt/origin -I -i /mnt/origin/tmp/perf.data \
     --kallsyms /mnt/origin/proc/kallsyms
  - complete perf.data header is displayed

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Tested-by: David Ahern <dsahern@gmail.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1337151548-2396-3-git-send-email-jolsa@redhat.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 2e49a948

tools/perf/util/session.c

+34 −0

Original line number	Diff line number	Diff line
		@@ -481,6 +481,38 @@ static void perf_event__read_swap(union perf_event *event)
		event->read.id = bswap_64(event->read.id);
		}

		static u8 revbyte(u8 b)
		{
		int rev = (b >> 4) \| ((b & 0xf) << 4);
		rev = ((rev & 0xcc) >> 2) \| ((rev & 0x33) << 2);
		rev = ((rev & 0xaa) >> 1) \| ((rev & 0x55) << 1);
		return (u8) rev;
		}

		/*
		* XXX this is hack in attempt to carry flags bitfield
		* throught endian village. ABI says:
		*
		* Bit-fields are allocated from right to left (least to most significant)
		* on little-endian implementations and from left to right (most to least
		* significant) on big-endian implementations.
		*
		* The above seems to be byte specific, so we need to reverse each
		* byte of the bitfield. 'Internet' also says this might be implementation
		* specific and we probably need proper fix and carry perf_event_attr
		* bitfield flags in separate data file FEAT_ section. Thought this seems
		* to work for now.
		*/
		static void swap_bitfield(u8 *p, unsigned len)
		{
		unsigned i;

		for (i = 0; i < len; i++) {
		p = revbyte(p);
		p++;
		}
		}

		/* exported for swapping attributes in file header */
		void perf_event__attr_swap(struct perf_event_attr *attr)
		{
		@@ -494,6 +526,8 @@ void perf_event__attr_swap(struct perf_event_attr *attr)
		attr->bp_type = bswap_32(attr->bp_type);
		attr->bp_addr = bswap_64(attr->bp_addr);
		attr->bp_len = bswap_64(attr->bp_len);

		swap_bitfield((u8 *) (&attr->read_format + 1), sizeof(u64));
		}

		static void perf_event__hdr_attr_swap(union perf_event *event)

Admin message