Commit e0e8f1c8 authored Jan 10, 2007 by Herbert Xu Committed by David S. Miller Jan 23, 2007

[IPSEC] flow: Fix potential memory leak



When old flow cache entries that are not at the head of their chain
trigger a transient security error they get unlinked along with all
the entries preceding them in the chain.  The preceding entries are
not freed correctly.

This patch fixes this by simply leaving the entry around.  It's based
on a suggestion by Venkat Yekkirala.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 419dd837

net/core/flow.c

+10 −16

Original line number	Diff line number	Diff line
		@@ -231,12 +231,7 @@ nocache:

		err = resolver(key, family, dir, &obj, &obj_ref);

		if (fle) {
		if (err) {
		/* Force security policy check on next lookup */
		*head = fle->next;
		flow_entry_kill(cpu, fle);
		} else {
		if (fle && !err) {
		fle->genid = atomic_read(&flow_cache_genid);

		if (fle->object)
		@@ -247,7 +242,6 @@ nocache:
		if (obj)
		atomic_inc(fle->object_ref);
		}
		}
		local_bh_enable();

		if (err)

Admin message