Commit e0e398e2 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM: runtime: Drop runtime PM references to supplier on link removal 



While removing a device link, drop the supplier device's runtime PM
usage counter as many times as needed to drop all of the runtime PM
references to it from the consumer in addition to dropping the
consumer's link count.

Fixes: baa8809f ("PM / runtime: Optimize the use of device links")
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: 5.1+ <stable@vger.kernel.org> # 5.1+
Tested-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3cea11cd

drivers/base/core.c

+2 −4
Original line number Diff line number Diff line
@@ -773,8 +773,7 @@ static void __device_link_del(struct kref *kref) 
	dev_dbg(link->consumer, "Dropping the link to %s\n",

		dev_name(link->supplier));



	if (link->flags & DL_FLAG_PM_RUNTIME)

		pm_runtime_drop_link(link->consumer);

	pm_runtime_drop_link(link);



	list_del_rcu(&link->s_node);

	list_del_rcu(&link->c_node);
@@ -788,8 +787,7 @@ static void __device_link_del(struct kref *kref) 
	dev_info(link->consumer, "Dropping the link to %s\n",

		 dev_name(link->supplier));



	if (link->flags & DL_FLAG_PM_RUNTIME)

		pm_runtime_drop_link(link->consumer);

	pm_runtime_drop_link(link);



	list_del(&link->s_node);

	list_del(&link->c_node);

drivers/base/power/runtime.c

+20 −1
Original line number Diff line number Diff line
@@ -1729,7 +1729,7 @@ void pm_runtime_new_link(struct device *dev) 
	spin_unlock_irq(&dev->power.lock);

}



void pm_runtime_drop_link(struct device *dev)

static void pm_runtime_drop_link_count(struct device *dev)

{

	spin_lock_irq(&dev->power.lock);

	WARN_ON(dev->power.links_count == 0);
@@ -1737,6 +1737,25 @@ void pm_runtime_drop_link(struct device *dev) 
	spin_unlock_irq(&dev->power.lock);

}



/**

 * pm_runtime_drop_link - Prepare for device link removal.

 * @link: Device link going away.

 *

 * Drop the link count of the consumer end of @link and decrement the supplier

 * device's runtime PM usage counter as many times as needed to drop all of the

 * PM runtime reference to it from the consumer.

 */

void pm_runtime_drop_link(struct device_link *link)

{

	if (!(link->flags & DL_FLAG_PM_RUNTIME))

		return;



	pm_runtime_drop_link_count(link->consumer);



	while (refcount_dec_not_one(&link->rpm_active))

		pm_runtime_put(link->supplier);

}



static bool pm_runtime_need_not_resume(struct device *dev)

{

	return atomic_read(&dev->power.usage_count) <= 1 &&

include/linux/pm_runtime.h

+2 −2
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ extern void pm_runtime_clean_up_links(struct device *dev); 
extern void pm_runtime_get_suppliers(struct device *dev);

extern void pm_runtime_put_suppliers(struct device *dev);

extern void pm_runtime_new_link(struct device *dev);

extern void pm_runtime_drop_link(struct device *dev);

extern void pm_runtime_drop_link(struct device_link *link);



/**

 * pm_runtime_get_if_in_use - Conditionally bump up runtime PM usage counter.
@@ -280,7 +280,7 @@ static inline void pm_runtime_clean_up_links(struct device *dev) {} 
static inline void pm_runtime_get_suppliers(struct device *dev) {}

static inline void pm_runtime_put_suppliers(struct device *dev) {}

static inline void pm_runtime_new_link(struct device *dev) {}

static inline void pm_runtime_drop_link(struct device *dev) {}

static inline void pm_runtime_drop_link(struct device_link *link) {}



#endif /* !CONFIG_PM */

CRA Git | Maintained and supported by SUSTech CRA and CCSE