opp: Reduce the size of critical section in _opp_table_kref_release() (e0df59de) · Commits · 戴 / test

There is a lot of stuff here which can be done outside of the big opp_table_lock, do that. This helps avoiding few circular dependency lockdeps around debugfs and interconnects. Reported-by:

Rob Clark <robdclark@gmail.com> Reported-by:

Dmitry Osipenko <digetx@gmail.com> Signed-off-by:

Viresh Kumar <viresh.kumar@linaro.org>

drivers/opp/core.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1181,6 +1181,10 @@ static void _opp_table_kref_release(struct kref *kref)
		struct opp_device opp_dev, temp;
		int i;

		/* Drop the lock as soon as we can */
		list_del(&opp_table->node);
		mutex_unlock(&opp_table_lock);

		_of_clear_opp_table(opp_table);

		/* Release clk */
		@@ -1208,10 +1212,7 @@ static void _opp_table_kref_release(struct kref *kref)

		mutex_destroy(&opp_table->genpd_virt_dev_lock);
		mutex_destroy(&opp_table->lock);
		list_del(&opp_table->node);
		kfree(opp_table);

		mutex_unlock(&opp_table_lock);
		}

		void dev_pm_opp_put_opp_table(struct opp_table *opp_table)

Admin message