Commit e0c79ff6 authored by Baoyou Xie's avatar Baoyou Xie Committed by David S. Miller
Browse files

lan78xx: mark symbols static where possible 



We get a few warnings when building kernel with W=1:
drivers/net/usb/lan78xx.c:1182:6: warning: no previous prototype for 'lan78xx_defer_kevent' [-Wmissing-prototypes]
drivers/net/usb/lan78xx.c:1409:5: warning: no previous prototype for 'lan78xx_nway_reset' [-Wmissing-prototypes]
drivers/net/usb/lan78xx.c:2000:5: warning: no previous prototype for 'lan78xx_set_mac_addr' [-Wmissing-prototypes]
....

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.

Signed-off-by: default avatarBaoyou Xie <baoyou.xie@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c63ad410

drivers/net/usb/lan78xx.c

+13 −11
Original line number Diff line number Diff line
@@ -1179,7 +1179,7 @@ static int lan78xx_link_reset(struct lan78xx_net *dev) 
 * NOTE:  annoying asymmetry:  if it's active, schedule_work() fails,

 * but tasklet_schedule() doesn't.	hope the failure is rare.

 */

void lan78xx_defer_kevent(struct lan78xx_net *dev, int work)

static void lan78xx_defer_kevent(struct lan78xx_net *dev, int work)

{

	set_bit(work, &dev->flags);

	if (!schedule_delayed_work(&dev->wq, 0))
@@ -1406,7 +1406,7 @@ static u32 lan78xx_get_link(struct net_device *net) 
	return net->phydev->link;

}



int lan78xx_nway_reset(struct net_device *net)

static int lan78xx_nway_reset(struct net_device *net)

{

	return phy_start_aneg(net->phydev);

}
@@ -1997,7 +1997,7 @@ static int lan78xx_change_mtu(struct net_device *netdev, int new_mtu) 
	return 0;

}



int lan78xx_set_mac_addr(struct net_device *netdev, void *p)

static int lan78xx_set_mac_addr(struct net_device *netdev, void *p)

{

	struct lan78xx_net *dev = netdev_priv(netdev);

	struct sockaddr *addr = p;
@@ -2371,7 +2371,7 @@ static void lan78xx_terminate_urbs(struct lan78xx_net *dev) 
	remove_wait_queue(&unlink_wakeup, &wait);

}



int lan78xx_stop(struct net_device *net)

static int lan78xx_stop(struct net_device *net)

{

	struct lan78xx_net		*dev = netdev_priv(net);
@@ -2533,7 +2533,8 @@ static void lan78xx_queue_skb(struct sk_buff_head *list, 
	entry->state = state;

}



netdev_tx_t lan78xx_start_xmit(struct sk_buff *skb, struct net_device *net)

static netdev_tx_t

lan78xx_start_xmit(struct sk_buff *skb, struct net_device *net)

{

	struct lan78xx_net *dev = netdev_priv(net);

	struct sk_buff *skb2 = NULL;
@@ -2562,7 +2563,8 @@ netdev_tx_t lan78xx_start_xmit(struct sk_buff *skb, struct net_device *net) 
	return NETDEV_TX_OK;

}



int lan78xx_get_endpoints(struct lan78xx_net *dev, struct usb_interface *intf)

static int

lan78xx_get_endpoints(struct lan78xx_net *dev, struct usb_interface *intf)

{

	int tmp;

	struct usb_host_interface *alt = NULL;
@@ -2700,7 +2702,7 @@ static void lan78xx_rx_csum_offload(struct lan78xx_net *dev, 
	}

}



void lan78xx_skb_return(struct lan78xx_net *dev, struct sk_buff *skb)

static void lan78xx_skb_return(struct lan78xx_net *dev, struct sk_buff *skb)

{

	int		status;
@@ -3283,7 +3285,7 @@ static void lan78xx_disconnect(struct usb_interface *intf) 
	usb_put_dev(udev);

}



void lan78xx_tx_timeout(struct net_device *net)

static void lan78xx_tx_timeout(struct net_device *net)

{

	struct lan78xx_net *dev = netdev_priv(net);
@@ -3603,7 +3605,7 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) 
	return 0;

}



int lan78xx_suspend(struct usb_interface *intf, pm_message_t message)

static int lan78xx_suspend(struct usb_interface *intf, pm_message_t message)

{

	struct lan78xx_net *dev = usb_get_intfdata(intf);

	struct lan78xx_priv *pdata = (struct lan78xx_priv *)(dev->data[0]);
@@ -3699,7 +3701,7 @@ out: 
	return ret;

}



int lan78xx_resume(struct usb_interface *intf)

static int lan78xx_resume(struct usb_interface *intf)

{

	struct lan78xx_net *dev = usb_get_intfdata(intf);

	struct sk_buff *skb;
@@ -3766,7 +3768,7 @@ int lan78xx_resume(struct usb_interface *intf) 
	return 0;

}



int lan78xx_reset_resume(struct usb_interface *intf)

static int lan78xx_reset_resume(struct usb_interface *intf)

{

	struct lan78xx_net *dev = usb_get_intfdata(intf);

CRA Git | Maintained and supported by SUSTech CRA and CCSE