Commit e0ad032e authored Oct 18, 2019 by Jakub Kicinski Committed by David S. Miller Oct 19, 2019

net: netem: correct the parent's backlog when corrupted packet was dropped



If packet corruption failed we jump to finish_segs and return
NET_XMIT_SUCCESS. Seeing success will make the parent qdisc
increment its backlog, that's incorrect - we need to return
NET_XMIT_DROP.

Fixes: 6071bd1a ("netem: Segment GSO packets on enqueue")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a7fa12d1

net/sched/sch_netem.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -616,6 +616,8 @@ finish_segs:
		}
		/* Parent qdiscs accounted for 1 skb of size @prev_len */
		qdisc_tree_reduce_backlog(sch, -(nb - 1), -(len - prev_len));
		} else if (!skb) {
		return NET_XMIT_DROP;
		}
		return NET_XMIT_SUCCESS;
		}

Admin message