xfs: add configuration handlers for specific errors (e0a431b3) · Commits · 戴 / test

now most of the infrastructure is in place, we can start adding support for configuring specific errors such as ENODEV, ENOSPC, EIO, etc. Add these error configurations and configure them all to have appropriate behaviours. That is, all will be configured to retry forever by default, except for ENODEV, which is an unrecoverable error, so it will be configured to not retry on error Signed-off-by:

Dave Chinner <dchinner@redhat.com> Signed-off-by:

Carlos Maiolino <cmaiolino@redhat.com> Reviewed-by:

Brian Foster <bfoster@redhat.com> Signed-off-by:

Dave Chinner <david@fromorbit.com>

fs/xfs/xfs_mount.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -49,6 +49,9 @@ enum {
		};
		enum {
		XFS_ERR_DEFAULT,
		XFS_ERR_EIO,
		XFS_ERR_ENOSPC,
		XFS_ERR_ENODEV,
		XFS_ERR_ERRNO_MAX,
		};

fs/xfs/xfs_sysfs.c

+21 −1

Original line number	Diff line number	Diff line
		@@ -478,9 +478,20 @@ struct xfs_error_init {

		static const struct xfs_error_init xfs_error_meta_init[XFS_ERR_ERRNO_MAX] = {
		{ .name = "default",
		.max_retries = -1,
		.max_retries = XFS_ERR_RETRY_FOREVER,
		.retry_timeout = 0,
		},
		{ .name = "EIO",
		.max_retries = XFS_ERR_RETRY_FOREVER,
		.retry_timeout = 0,
		},
		{ .name = "ENOSPC",
		.max_retries = XFS_ERR_RETRY_FOREVER,
		.retry_timeout = 0,
		},
		{ .name = "ENODEV",
		.max_retries = 0,
		},
		};

		static int
		@@ -578,6 +589,15 @@ xfs_error_get_cfg(
		struct xfs_error_cfg *cfg;

		switch (error) {
		case EIO:
		cfg = &mp->m_error_cfg[error_class][XFS_ERR_EIO];
		break;
		case ENOSPC:
		cfg = &mp->m_error_cfg[error_class][XFS_ERR_ENOSPC];
		break;
		case ENODEV:
		cfg = &mp->m_error_cfg[error_class][XFS_ERR_ENODEV];
		break;
		default:
		cfg = &mp->m_error_cfg[error_class][XFS_ERR_DEFAULT];
		break;

Admin message