Commit e0a31262 authored Nov 07, 2019 by David Ahern Committed by David S. Miller Nov 07, 2019

ipv4: Fix table id reference in fib_sync_down_addr



Hendrik reported routes in the main table using source address are not
removed when the address is removed. The problem is that fib_sync_down_addr
does not account for devices in the default VRF which are associated
with the main table. Fix by updating the table id reference.

Fixes: 5a56a0b3 ("net: Don't delete routes in different VRFs")
Reported-by: Hendrik Donner <hd@os-cillation.de>
Signed-off-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1bef4c22

net/ipv4/fib_semantics.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1814,8 +1814,8 @@ int fib_sync_down_addr(struct net_device *dev, __be32 local)
		int ret = 0;
		unsigned int hash = fib_laddr_hashfn(local);
		struct hlist_head *head = &fib_info_laddrhash[hash];
		int tb_id = l3mdev_fib_table(dev) ? : RT_TABLE_MAIN;
		struct net *net = dev_net(dev);
		int tb_id = l3mdev_fib_table(dev);
		struct fib_info *fi;

		if (!fib_info_laddrhash \|\| local == 0)

Admin message