Commit e09a7440 authored Mar 26, 2020 by Gustavo A. R. Silva Committed by Geert Uytterhoeven Apr 20, 2020

m68k: amiga: config: Mark expected switch fall-through



Mark switch cases where we are expecting to fall through.

This patch fixes the following warning (Building: allmodconfig m68k):

arch/m68k/amiga/config.c: In function ‘amiga_identify’:
./arch/m68k/include/asm/amigahw.h:42:50: warning: this statement may fall through [-Wimplicit-fallthrough=]
 #define AMIGAHW_SET(name) (amiga_hw_present.name = 1)
                           ~~~~~~~~~~~~~~~~~~~~~~~^~~~
arch/m68k/amiga/config.c:223:3: note: in expansion of macro ‘AMIGAHW_SET’
   AMIGAHW_SET(PCMCIA);
   ^~~~~~~~~~~
arch/m68k/amiga/config.c:224:2: note: here
  case AMI_500:
  ^~~~

Replace the existing /* fall through */ comments and fix the issue above
by using the new pseudo-keyword fallthrough;

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/14ff577604d25243c8a897f851b436ba87ae87cb.1585264062.git.gustavo@embeddedor.com


Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

parent 8f3d9f35

arch/m68k/amiga/config.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -221,6 +221,7 @@ static void __init amiga_identify(void)
		case AMI_1200:
		AMIGAHW_SET(A1200_IDE);
		AMIGAHW_SET(PCMCIA);
		fallthrough;
		case AMI_500:
		case AMI_500PLUS:
		case AMI_1000:
		@@ -233,7 +234,7 @@ static void __init amiga_identify(void)
		case AMI_3000T:
		AMIGAHW_SET(AMBER_FF);
		AMIGAHW_SET(MAGIC_REKICK);
		/* fall through */
		fallthrough;
		case AMI_3000PLUS:
		AMIGAHW_SET(A3000_SCSI);
		AMIGAHW_SET(A3000_CLK);
		@@ -242,7 +243,7 @@ static void __init amiga_identify(void)

		case AMI_4000T:
		AMIGAHW_SET(A4000_SCSI);
		/* fall through */
		fallthrough;
		case AMI_4000:
		AMIGAHW_SET(A4000_IDE);
		AMIGAHW_SET(A3000_CLK);

Admin message