Commit e095882e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Chanwoo Choi
Browse files

extcon: ptn5150: Simplify getting vbus-gpios with flags 



Instead of obtaining GPIO as input and configuring it right after to
output-low, just use proper GPIOD_OUT_LOW flag.  Code is smaller and
simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarVijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 45ce36f5

drivers/extcon/extcon-ptn5150.c

+1 −6
Original line number Diff line number Diff line
@@ -239,16 +239,11 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c, 


	info->dev = &i2c->dev;

	info->i2c = i2c;

	info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);

	info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_OUT_LOW);

	if (IS_ERR(info->vbus_gpiod)) {

		dev_err(dev, "failed to get VBUS GPIO\n");

		return PTR_ERR(info->vbus_gpiod);

	}

	ret = gpiod_direction_output(info->vbus_gpiod, 0);

	if (ret) {

		dev_err(dev, "failed to set VBUS GPIO direction\n");

		return -EINVAL;

	}



	mutex_init(&info->mutex);

CRA Git | Maintained and supported by SUSTech CRA and CCSE