sunrpc: Prevent resvport min/max inversion via sysctl (e08ea3a9) · Commits · 戴 / test

The current min/max resvport settings are independently limited by the entire range of allowed ports, so max_resvport can be set to a port lower than min_resvport. Prevent inversion of min/max values when set through sysctl by setting the limits dependent on each other. Signed-off-by:

Frank Sorenson <sorenson@redhat.com> Signed-off-by:

Trond Myklebust <trond.myklebust@primarydata.com>

net/sunrpc/xprtsock.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -124,7 +124,7 @@ static struct ctl_table xs_tunables_table[] = {
		.mode = 0644,
		.proc_handler = proc_dointvec_minmax,
		.extra1 = &xprt_min_resvport_limit,
		.extra2 = &xprt_max_resvport_limit
		.extra2 = &xprt_max_resvport
		},
		{
		.procname = "max_resvport",
		@@ -132,7 +132,7 @@ static struct ctl_table xs_tunables_table[] = {
		.maxlen = sizeof(unsigned int),
		.mode = 0644,
		.proc_handler = proc_dointvec_minmax,
		.extra1 = &xprt_min_resvport_limit,
		.extra1 = &xprt_min_resvport,
		.extra2 = &xprt_max_resvport_limit
		},
		{

Admin message