Commit e08b1877 authored Nov 02, 2017 by Florian Fainelli Committed by Linus Torvalds Nov 03, 2017

initramfs: fix initramfs rebuilds w/ compression after disabling

This is a follow-up to commit 57ddfdaa ("initramfs: fix disabling of
initramfs (and its compression)").  This particular commit fixed the use
case where we build the kernel with an initramfs with no compression,
and then we build the kernel with no initramfs.

Now this still left us with the same case as described here:

  http://lkml.kernel.org/r/20170521033337.6197-1-f.fainelli@gmail.com

not working with initramfs compression.  This can be seen by the
following steps/timestamps:

  https://www.spinics.net/lists/kernel/msg2598153.html

.initramfs_data.cpio.gz.cmd is correct:

  cmd_usr/initramfs_data.cpio.gz := /bin/bash
  ./scripts/gen_initramfs_list.sh -o usr/initramfs_data.cpio.gz  -u 1000 -g 1000  /home/fainelli/work/uclinux-rootfs/romfs /home/fainelli/work/uclinux-rootfs/misc/initramfs.dev

and was generated the first time we did generate the gzip initramfs, so
the command has not changed, nor its arguments, so we just don't call
it, no initramfs cpio is re-generated as a consequence.

The fix for this problem is just to properly keep track of the
.initramfs_cpio_data.d file by suffixing it with the compression
extension.  This takes care of properly tracking dependencies such that
the initramfs get (re)generated any time files are added/deleted etc.

Link: http://lkml.kernel.org/r/20170930033936.6722-1-f.fainelli@gmail.com


Fixes: db2aa7fd ("initramfs: allow again choice of the embedded initramfs compression algorithm")
Fixes: 9e3596b0 ("kbuild: initramfs cleanup, set target from Kconfig")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Francisco Blas Izquierdo Riera (klondike)" <klondike@xiscosoft.net>
Cc: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ab615a5b

usr/Makefile

+5 −4

Original line number	Diff line number	Diff line
		@@ -8,6 +8,7 @@ PHONY += klibcdirs

		suffix_y = $(subst $\",,$(CONFIG_INITRAMFS_COMPRESSION))
		datafile_y = initramfs_data.cpio$(suffix_y)
		datafile_d_y = .$(datafile_y).d
		AFLAGS_initramfs_data.o += -DINITRAMFS_IMAGE="usr/$(datafile_y)"


		@@ -30,12 +31,12 @@ ramfs-args := \
		$(if $(CONFIG_INITRAMFS_ROOT_UID), -u $(CONFIG_INITRAMFS_ROOT_UID)) \
		$(if $(CONFIG_INITRAMFS_ROOT_GID), -g $(CONFIG_INITRAMFS_ROOT_GID))

		# .initramfs_data.cpio.d is used to identify all files included
		# $(datafile_d_y) is used to identify all files included
		# in initramfs and to detect if any files are added/removed.
		# Removed files are identified by directory timestamp being updated
		# The dependency list is generated by gen_initramfs.sh -l
		ifneq ($(wildcard $(obj)/.initramfs_data.cpio.d),)
		include $(obj)/.initramfs_data.cpio.d
		ifneq ($(wildcard $(obj)/$(datafile_d_y)),)
		include $(obj)/$(datafile_d_y)
		endif

		quiet_cmd_initfs = GEN $@
		@@ -53,5 +54,5 @@ $(deps_initramfs): klibcdirs
		# 3) If gen_init_cpio are newer than initramfs_data.cpio
		# 4) arguments to gen_initramfs.sh changes
		$(obj)/$(datafile_y): $(obj)/gen_init_cpio $(deps_initramfs) klibcdirs
		$(Q)$(initramfs) -l $(ramfs-input) > $(obj)/.initramfs_data.cpio.d
		$(Q)$(initramfs) -l $(ramfs-input) > $(obj)/$(datafile_d_y)
		$(call if_changed,initfs)

Admin message