Commit e0830dbf authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

serial: core: fix console port-lock regression 



Fix the port-lock initialisation regression introduced by commit
a3cb39d2 ("serial: core: Allow detach and attach serial device for
console") by making sure that the lock is again initialised during
console setup.

The console may be registered before the serial controller has been
probed in which case the port lock needs to be initialised during
console setup by a call to uart_set_options(). The console-detach
changes introduced a regression in several drivers by effectively
removing that initialisation by not initialising the lock when the port
is used as a console (which is always the case during console setup).

Add back the early lock initialisation and instead use a new
console-reinit flag to handle the case where a console is being
re-attached through sysfs.

The question whether the console-detach interface should have been added
in the first place is left for another discussion.

Note that the console-enabled check in uart_set_options() is not
redundant because of kgdboc, which can end up reinitialising an already
enabled console (see commit 42b6a1ba ("serial_core: Don't
re-initialize a previously initialized spinlock.")).

Fixes: a3cb39d2 ("serial: core: Allow detach and attach serial device for console")
Cc: stable <stable@vger.kernel.org>     # 5.7
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200909143101.15389-3-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fe88c648

drivers/tty/serial/serial_core.c

+15 −17
Original line number Diff line number Diff line
@@ -1916,24 +1916,12 @@ static inline bool uart_console_enabled(struct uart_port *port) 
	return uart_console(port) && (port->cons->flags & CON_ENABLED);

}



static void __uart_port_spin_lock_init(struct uart_port *port)

static void uart_port_spin_lock_init(struct uart_port *port)

{

	spin_lock_init(&port->lock);

	lockdep_set_class(&port->lock, &port_lock_key);

}



/*

 * Ensure that the serial console lock is initialised early.

 * If this port is a console, then the spinlock is already initialised.

 */

static inline void uart_port_spin_lock_init(struct uart_port *port)

{

	if (uart_console(port))

		return;



	__uart_port_spin_lock_init(port);

}



#if defined(CONFIG_SERIAL_CORE_CONSOLE) || defined(CONFIG_CONSOLE_POLL)

/**

 *	uart_console_write - write a console message to a serial port
@@ -2086,6 +2074,14 @@ uart_set_options(struct uart_port *port, struct console *co, 
	struct ktermios termios;

	static struct ktermios dummy;



	/*

	 * Ensure that the serial-console lock is initialised early.

	 *

	 * Note that the console-enabled check is needed because of kgdboc,

	 * which can end up calling uart_set_options() for an already enabled

	 * console via tty_find_polling_driver() and uart_poll_init().

	 */

	if (!uart_console_enabled(port) && !port->console_reinit)

		uart_port_spin_lock_init(port);



	memset(&termios, 0, sizeof(struct ktermios));
@@ -2794,11 +2790,13 @@ static ssize_t console_store(struct device *dev, 
		if (oldconsole && !newconsole) {

			ret = unregister_console(uport->cons);

		} else if (!oldconsole && newconsole) {

			if (uart_console(uport))

			if (uart_console(uport)) {

				uport->console_reinit = 1;

				register_console(uport->cons);

			else

			} else {

				ret = -ENOENT;

			}

		}

	} else {

		ret = -ENXIO;

	}
@@ -2898,7 +2896,7 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport) 
	 * initialised.

	 */

	if (!uart_console_enabled(uport))

		__uart_port_spin_lock_init(uport);

		uart_port_spin_lock_init(uport);



	if (uport->cons && uport->dev)

		of_console_check(uport->dev->of_node, uport->cons->name, uport->line);

include/linux/serial_core.h

+1 −0
Original line number Diff line number Diff line
@@ -248,6 +248,7 @@ struct uart_port { 


	unsigned char		hub6;			/* this should be in the 8250 driver */

	unsigned char		suspended;

	unsigned char		console_reinit;

	const char		*name;			/* port name */

	struct attribute_group	*attr_group;		/* port specific attributes */

	const struct attribute_group **tty_groups;	/* all attributes (serial core use only) */

CRA Git | Maintained and supported by SUSTech CRA and CCSE