Commit e0714ec4 authored May 27, 2016 by Linus Torvalds

nfs: fix anonymous member initializer build failure with older compilers

Older versions of gcc don't understand named initializers inside a
anonymous structure or union member. It can be worked around by adding
the bracin gin the initializer for the anonymous member.

Without this, gcc 4.4.4 will fail the build with

CC fs/nfs/nfs4state.o
fs/nfs/nfs4state.c:69: error: unknown field ‘data’ specified in initializer
fs/nfs/nfs4state.c:69: warning: missing braces around initializer
fs/nfs/nfs4state.c:69: warning: (near initialization for ‘zero_stateid.<anonymous>.data’)
make[2]: *** [fs/nfs/nfs4state.o] Error 1

introduced in commit 93b717fd ("NFSv4: Label stateids with the type")

Reported-and-tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d102a56e

fs/nfs/nfs4state.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -66,7 +66,7 @@
		#define OPENOWNER_POOL_SIZE 8

		const nfs4_stateid zero_stateid = {
		.data = { 0 },
		{ .data = { 0 } },
		.type = NFS4_SPECIAL_STATEID_TYPE,
		};
		static DEFINE_MUTEX(nfs_clid_init_mutex);

Admin message