Commit e0712baa authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf trace: Wire up strarray__strtoul_flags() 

Now anything that uses STRARRAY_FLAGS, like the 'fsmount' syscall will
support mapping or-ed strings back to a value that can be used in a
filter.

In some cases, where STRARRAY_FLAGS isn't used but instead the scnprintf
is a special one because of specific needs, like for mmap, then one has
to set the ->pars to the strarray. See the next cset.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-r2lpqo7dfsrhi4ll0npsb3u7@git.kernel.org


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 154c978d

tools/perf/builtin-trace.c

+6 −0
Original line number Diff line number Diff line
@@ -540,6 +540,11 @@ bool syscall_arg__strtoul_strarray(char *bf, size_t size, struct syscall_arg *ar 
	return strarray__strtoul(arg->parm, bf, size, ret);

}



bool syscall_arg__strtoul_strarray_flags(char *bf, size_t size, struct syscall_arg *arg, u64 *ret)

{

	return strarray__strtoul_flags(arg->parm, bf, size, ret);

}



bool syscall_arg__strtoul_strarrays(char *bf, size_t size, struct syscall_arg *arg, u64 *ret)

{

	return strarrays__strtoul(arg->parm, bf, size, ret);
@@ -882,6 +887,7 @@ static size_t syscall_arg__scnprintf_getrandom_flags(char *bf, size_t size, 


#define STRARRAY_FLAGS(name, array) \

	  { .scnprintf	= SCA_STRARRAY_FLAGS, \

	    .strtoul	= STUL_STRARRAY_FLAGS, \

	    .parm	= &strarray__##array, }



#include "trace/beauty/arch_errno_names.c"

tools/perf/trace/beauty/beauty.h

+3 −0
Original line number Diff line number Diff line
@@ -126,6 +126,9 @@ size_t syscall_arg__scnprintf_strarray_flags(char *bf, size_t size, struct sysca 
bool syscall_arg__strtoul_strarray(char *bf, size_t size, struct syscall_arg *arg, u64 *ret);

#define STUL_STRARRAY syscall_arg__strtoul_strarray



bool syscall_arg__strtoul_strarray_flags(char *bf, size_t size, struct syscall_arg *arg, u64 *ret);

#define STUL_STRARRAY_FLAGS syscall_arg__strtoul_strarray_flags



bool syscall_arg__strtoul_strarrays(char *bf, size_t size, struct syscall_arg *arg, u64 *ret);

#define STUL_STRARRAYS syscall_arg__strtoul_strarrays

CRA Git | Maintained and supported by SUSTech CRA and CCSE