Commit e0664ebc authored Apr 30, 2020 by Wei Yongjun Committed by Herbert Xu May 08, 2020

crypto: drbg - fix error return code in drbg_alloc_state()



Fix to return negative error code -ENOMEM from the kzalloc error handling
case instead of 0, as done elsewhere in this function.

Reported-by: Xiumei Mu <xmu@redhat.com>
Fixes: db07cd26 ("crypto: drbg - add FIPS 140-2 CTRNG for noise source")
Cc: <stable@vger.kernel.org>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent c5492269

crypto/drbg.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1306,8 +1306,10 @@ static inline int drbg_alloc_state(struct drbg_state *drbg)
		if (IS_ENABLED(CONFIG_CRYPTO_FIPS)) {
		drbg->prev = kzalloc(drbg_sec_strength(drbg->core->flags),
		GFP_KERNEL);
		if (!drbg->prev)
		if (!drbg->prev) {
		ret = -ENOMEM;
		goto fini;
		}
		drbg->fips_primed = false;
		}

Admin message