clk: renesas: Use pm_clk_no_clocks() helper i.s.o. direct access (e05e853e) · Commits · 戴 / test

The pm_subsys_data.clock_list member exists only if CONFIG_PM_CLK=y. Hence direct accesses to this field break compile-testing on platforms where CONFIG_PM_CLK=n. To fix this, use the pm_clk_no_clocks() helper instead, for which a dummy version is provided if CONFIG_PM_CLK=n. Signed-off-by:

Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:

Simon Horman <simon.horman@netronome.com>

drivers/clk/renesas/clk-mstp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -325,7 +325,7 @@ fail_put:

		void cpg_mstp_detach_dev(struct generic_pm_domain unused, struct device dev)
		{
		if (!list_empty(&dev->power.subsys_data->clock_list))
		if (!pm_clk_no_clocks(dev))
		pm_clk_destroy(dev);
		}

drivers/clk/renesas/renesas-cpg-mssr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -477,7 +477,7 @@ fail_put:

		void cpg_mssr_detach_dev(struct generic_pm_domain unused, struct device dev)
		{
		if (!list_empty(&dev->power.subsys_data->clock_list))
		if (!pm_clk_no_clocks(dev))
		pm_clk_destroy(dev);
		}

Admin message