Commit e033b6c1 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM: QoS: Adjust pm_qos_request() signature and reorder pm_qos.h 



Change the return type of pm_qos_request() to be the same as the
one of pm_qos_read_value() called by it internally and stop exporting
it to modules (because its only caller, cpuidle, is not modular).

Also move the pm_qos_read_value() header away from the CPU latency
QoS API function headers in pm_qos.h (because it technically does
not belong to that API).

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Reviewed-by: default avatarAmit Kucheria <amit.kucheria@linaro.org>
Tested-by: default avatarAmit Kucheria <amit.kucheria@linaro.org>
parent 333eed7d

include/linux/pm_qos.h

+3 −3
Original line number Diff line number Diff line
@@ -137,20 +137,20 @@ static inline int dev_pm_qos_request_active(struct dev_pm_qos_request *req) 
	return req->dev != NULL;

}



s32 pm_qos_read_value(struct pm_qos_constraints *c);

int pm_qos_update_target(struct pm_qos_constraints *c, struct plist_node *node,

			 enum pm_qos_req_action action, int value);

bool pm_qos_update_flags(struct pm_qos_flags *pqf,

			 struct pm_qos_flags_request *req,

			 enum pm_qos_req_action action, s32 val);



void pm_qos_add_request(struct pm_qos_request *req, int pm_qos_class,

			s32 value);

void pm_qos_update_request(struct pm_qos_request *req,

			   s32 new_value);

void pm_qos_remove_request(struct pm_qos_request *req);



int pm_qos_request(int pm_qos_class);

s32 pm_qos_request(int pm_qos_class);

int pm_qos_request_active(struct pm_qos_request *req);

s32 pm_qos_read_value(struct pm_qos_constraints *c);



#ifdef CONFIG_PM

enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev, s32 mask);

kernel/power/qos.c

+1 −2
Original line number Diff line number Diff line
@@ -235,11 +235,10 @@ static struct pm_qos_constraints cpu_latency_constraints = { 
 *

 * This function returns the current target value.

 */

int pm_qos_request(int pm_qos_class)

s32 pm_qos_request(int pm_qos_class)

{

	return pm_qos_read_value(&cpu_latency_constraints);

}

EXPORT_SYMBOL_GPL(pm_qos_request);



int pm_qos_request_active(struct pm_qos_request *req)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE