dt-bindings: net: phy: mscc: vsc8531: factorize vsc8531, led-N-mode (e02eef31) · Commits · 戴 / test

VSC8584 supports 4 LEDs while VSC8531 only supports 2. Let's factorize the documentation for LED mode properties and give the 4 default values (the first two being shared between VSC8531 and VSC8584). Reviewed-by:

Rob Herring <robh@kernel.org> Signed-off-by:

Quentin Schulz <quentin.schulz@bootlin.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt

+9 −7

Original line number	Diff line number	Diff line
		@@ -22,14 +22,16 @@ Optional properties:
		'vddmac'.
		Default value is 0%.
		Ref: Table:1 - Edge rate change (below).
		- vsc8531,led-0-mode : LED mode. Specify how the LED[0] should behave.
		Allowed values are define in
		- vsc8531,led-[N]-mode : LED mode. Specify how the LED[N] should behave.
		N depends on the number of LEDs supported by a
		PHY.
		Allowed values are defined in
		"include/dt-bindings/net/mscc-phy-vsc8531.h".
		Default value is VSC8531_LINK_1000_ACTIVITY (1).
		- vsc8531,led-1-mode : LED mode. Specify how the LED[1] should behave.
		Allowed values are define in
		"include/dt-bindings/net/mscc-phy-vsc8531.h".
		Default value is VSC8531_LINK_100_ACTIVITY (2).
		Default values are VSC8531_LINK_1000_ACTIVITY (1),
		VSC8531_LINK_100_ACTIVITY (2),
		VSC8531_LINK_ACTIVITY (0) and
		VSC8531_DUPLEX_COLLISION (8).


		Table: 1 - Edge rate change
		----------------------------------------------------------------\|

Admin message