Commit e027a2de authored Aug 19, 2019 by Wenwen Wang Committed by Guenter Roeck Aug 31, 2019

hwmon (coretemp) Fix a memory leak bug



In coretemp_init(), 'zone_devices' is allocated through kcalloc().
However, it is not deallocated in the following execution if
platform_driver_register() fails, leading to a memory leak. To fix this
issue, introduce the 'outzone' label to free 'zone_devices' before
returning the error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Link: https://lore.kernel.org/r/1566248402-6538-1-git-send-email-wenwen@cs.uga.edu


Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 7d82fcc9

drivers/hwmon/coretemp.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -736,7 +736,7 @@ static int __init coretemp_init(void)

		err = platform_driver_register(&coretemp_driver);
		if (err)
		return err;
		goto outzone;

		err = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "hwmon/coretemp:online",
		coretemp_cpu_online, coretemp_cpu_offline);
		@@ -747,6 +747,7 @@ static int __init coretemp_init(void)

		outdrv:
		platform_driver_unregister(&coretemp_driver);
		outzone:
		kfree(zone_devices);
		return err;
		}

Admin message