Commit e00f4f4d authored by Tejun Heo's avatar Tejun Heo Committed by Jens Axboe
Browse files

block,blkcg: use __GFP_NOWARN for best-effort allocations in blkcg 



blkcg allocates some per-cgroup data structures with GFP_NOWAIT and
when that fails falls back to operations which aren't specific to the
cgroup.  Occassional failures are expected under pressure and falling
back to non-cgroup operation is the right thing to do.

Unfortunately, I forgot to add __GFP_NOWARN to these allocations and
these expected failures end up creating a lot of noise.  Add
__GFP_NOWARN.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Reported-by: default avatarMarc MERLIN <marc@merlins.org>
Reported-by: default avatarVlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 05aea81b

block/blk-cgroup.c

+5 −4
Original line number Original line Diff line number Diff line
@@ -185,7 +185,8 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg, 
	}

	}





	wb_congested = wb_congested_get_create(&q->backing_dev_info,

	wb_congested = wb_congested_get_create(&q->backing_dev_info,

					       blkcg->css.id, GFP_NOWAIT);

					       blkcg->css.id,

					       GFP_NOWAIT | __GFP_NOWARN);

	if (!wb_congested) {

	if (!wb_congested) {

		ret = -ENOMEM;

		ret = -ENOMEM;

		goto err_put_css;

		goto err_put_css;
@@ -193,7 +194,7 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg, 




	/* allocate */

	/* allocate */

	if (!new_blkg) {

	if (!new_blkg) {

		new_blkg = blkg_alloc(blkcg, q, GFP_NOWAIT);

		new_blkg = blkg_alloc(blkcg, q, GFP_NOWAIT | __GFP_NOWARN);

		if (unlikely(!new_blkg)) {

		if (unlikely(!new_blkg)) {

			ret = -ENOMEM;

			ret = -ENOMEM;

			goto err_put_congested;

			goto err_put_congested;
@@ -1022,7 +1023,7 @@ blkcg_css_alloc(struct cgroup_subsys_state *parent_css) 
	}

	}





	spin_lock_init(&blkcg->lock);

	spin_lock_init(&blkcg->lock);

	INIT_RADIX_TREE(&blkcg->blkg_tree, GFP_NOWAIT);

	INIT_RADIX_TREE(&blkcg->blkg_tree, GFP_NOWAIT | __GFP_NOWARN);

	INIT_HLIST_HEAD(&blkcg->blkg_list);

	INIT_HLIST_HEAD(&blkcg->blkg_list);

#ifdef CONFIG_CGROUP_WRITEBACK

#ifdef CONFIG_CGROUP_WRITEBACK

	INIT_LIST_HEAD(&blkcg->cgwb_list);

	INIT_LIST_HEAD(&blkcg->cgwb_list);
@@ -1240,7 +1241,7 @@ pd_prealloc: 
		if (blkg->pd[pol->plid])

		if (blkg->pd[pol->plid])

			continue;

			continue;





		pd = pol->pd_alloc_fn(GFP_NOWAIT, q->node);

		pd = pol->pd_alloc_fn(GFP_NOWAIT | __GFP_NOWARN, q->node);

		if (!pd)

		if (!pd)

			swap(pd, pd_prealloc);

			swap(pd, pd_prealloc);

		if (!pd) {

		if (!pd) {

block/cfq-iosched.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -3859,7 +3859,8 @@ cfq_get_queue(struct cfq_data *cfqd, bool is_sync, struct cfq_io_cq *cic, 
			goto out;

			goto out;

	}

	}





	cfqq = kmem_cache_alloc_node(cfq_pool, GFP_NOWAIT | __GFP_ZERO,

	cfqq = kmem_cache_alloc_node(cfq_pool,

				     GFP_NOWAIT | __GFP_ZERO | __GFP_NOWARN,

				     cfqd->queue->node);

				     cfqd->queue->node);

	if (!cfqq) {

	if (!cfqq) {

		cfqq = &cfqd->oom_cfqq;

		cfqq = &cfqd->oom_cfqq;

CRA Git | Maintained and supported by SUSTech CRA and CCSE