rcu: Semicolon inside RCU_TRACE() for rcu.h (dffd06a7) · Commits · 戴 / test

The current use of "RCU_TRACE(statement);" can cause odd bugs, especially where "statement" is a local-variable declaration, as it can leave a misplaced ";" in the source code. This commit therefore converts these to "RCU_TRACE(statement;)", which avoids the misplaced ";". Reported-by:

Josh Triplett <josh@joshtriplett.org> Signed-off-by:

Paul E. McKenney <paulmck@linux.vnet.ibm.com>

kernel/rcu/rcu.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -109,12 +109,12 @@ static inline bool __rcu_reclaim(const char rn, struct rcu_head head)

		rcu_lock_acquire(&rcu_callback_map);
		if (__is_kfree_rcu_offset(offset)) {
		RCU_TRACE(trace_rcu_invoke_kfree_callback(rn, head, offset));
		RCU_TRACE(trace_rcu_invoke_kfree_callback(rn, head, offset);)
		kfree((void *)head - offset);
		rcu_lock_release(&rcu_callback_map);
		return true;
		} else {
		RCU_TRACE(trace_rcu_invoke_callback(rn, head));
		RCU_TRACE(trace_rcu_invoke_callback(rn, head);)
		head->func(head);
		rcu_lock_release(&rcu_callback_map);
		return false;

Admin message