Commit dfe816c5 authored by Pankaj Gupta's avatar Pankaj Gupta Committed by David S. Miller
Browse files

macvtap: Increase limit of macvtap queues 



Macvtap should be compatible with tuntap for
maximum number of queues.

commit 'baf71c5c (tuntap:
Increase the number of queues in tun.)' removes
the limitations and increases number of queues in tuntap.
Now, Its safe to increase number of queues in Macvtap as well.

This patch also modifies 'macvtap_del_queues' function
to avoid extra memory allocation in stack.

Changes from v1->v2 :
Michael S. Tsirkin, Jason Wang  :
                  Better way to use linked list to
avoid use of extra memory in stack.
Sergei Shtylyov : Specify dependent commit's summary.

Signed-off-by: default avatarPankaj Gupta <pagupta@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0fb1170e

drivers/net/macvtap.c

+2 −8
Original line number Diff line number Diff line
@@ -263,27 +263,21 @@ out: 
static void macvtap_del_queues(struct net_device *dev)

{

	struct macvlan_dev *vlan = netdev_priv(dev);

	struct macvtap_queue *q, *tmp, *qlist[MAX_MACVTAP_QUEUES];

	int i, j = 0;

	struct macvtap_queue *q, *tmp;



	ASSERT_RTNL();

	list_for_each_entry_safe(q, tmp, &vlan->queue_list, next) {

		list_del_init(&q->next);

		qlist[j++] = q;

		RCU_INIT_POINTER(q->vlan, NULL);

		if (q->enabled)

			vlan->numvtaps--;

		vlan->numqueues--;

		sock_put(&q->sk);

	}

	for (i = 0; i < vlan->numvtaps; i++)

		RCU_INIT_POINTER(vlan->taps[i], NULL);

	BUG_ON(vlan->numvtaps);

	BUG_ON(vlan->numqueues);

	/* guarantee that any future macvtap_set_queue will fail */

	vlan->numvtaps = MAX_MACVTAP_QUEUES;



	for (--j; j >= 0; j--)

		sock_put(&qlist[j]->sk);

}



static rx_handler_result_t macvtap_handle_frame(struct sk_buff **pskb)

include/linux/if_macvlan.h

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ struct macvtap_queue; 
 * Maximum times a macvtap device can be opened. This can be used to

 * configure the number of receive queue, e.g. for multiqueue virtio.

 */

#define MAX_MACVTAP_QUEUES	16

#define MAX_MACVTAP_QUEUES	256



#define MACVLAN_MC_FILTER_BITS	8

#define MACVLAN_MC_FILTER_SZ	(1 << MACVLAN_MC_FILTER_BITS)

CRA Git | Maintained and supported by SUSTech CRA and CCSE