Commit dfe40ca4 authored by Mika Westerberg's avatar Mika Westerberg
Browse files

thunderbolt: Assign remote for both ports in case of dual link 



Currently the driver only assigns remote port for the primary port if in
case of dual link. This makes things such as walking from one port to
another more complex than necessary because the code needs to change
from secondary to primary port if the path that is established is
created using secondary links.

In order to always assign both remote pointers we need to prevent the
scanning code from following the secondary link. Failing to do that
might cause problems as the same switch may be enumerated twice (or
removed in case of unplug). Handle that properly by introducing a new
function tb_port_has_remote() that returns true only for the primary
port. We also update tb_is_upstream_port() to support both dual link
ports, make it take const port pointer and move it below
tb_upstream_port() to keep similar functions close.

Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 0b2863ac

drivers/thunderbolt/icm.c

+10 −23
Original line number Diff line number Diff line
@@ -1761,15 +1761,9 @@ static void icm_unplug_children(struct tb_switch *sw) 
	for (i = 1; i <= sw->config.max_port_number; i++) {

		struct tb_port *port = &sw->ports[i];



		if (tb_is_upstream_port(port))

			continue;

		if (port->xdomain) {

		if (port->xdomain)

			port->xdomain->is_unplugged = true;

			continue;

		}

		if (!port->remote)

			continue;



		else if (tb_port_has_remote(port))

			icm_unplug_children(port->remote->sw);

	}

}
@@ -1781,18 +1775,10 @@ static void icm_free_unplugged_children(struct tb_switch *sw) 
	for (i = 1; i <= sw->config.max_port_number; i++) {

		struct tb_port *port = &sw->ports[i];



		if (tb_is_upstream_port(port))

			continue;



		if (port->xdomain && port->xdomain->is_unplugged) {

			tb_xdomain_remove(port->xdomain);

			port->xdomain = NULL;

			continue;

		}



		if (!port->remote)

			continue;



		} else if (tb_port_has_remote(port)) {

			if (port->remote->sw->is_unplugged) {

				tb_switch_remove(port->remote->sw);

				port->remote = NULL;
@@ -1801,6 +1787,7 @@ static void icm_free_unplugged_children(struct tb_switch *sw) 
			}

		}

	}

}



static void icm_rescan_work(struct work_struct *work)

{

drivers/thunderbolt/switch.c

+10 −11
Original line number Diff line number Diff line
@@ -1580,15 +1580,14 @@ void tb_switch_remove(struct tb_switch *sw) 


	/* port 0 is the switch itself and never has a remote */

	for (i = 1; i <= sw->config.max_port_number; i++) {

		if (tb_is_upstream_port(&sw->ports[i]))

			continue;

		if (sw->ports[i].remote)

		if (tb_port_has_remote(&sw->ports[i])) {

			tb_switch_remove(sw->ports[i].remote->sw);

			sw->ports[i].remote = NULL;

		if (sw->ports[i].xdomain)

		} else if (sw->ports[i].xdomain) {

			tb_xdomain_remove(sw->ports[i].xdomain);

			sw->ports[i].xdomain = NULL;

		}

	}



	if (!sw->is_unplugged)

		tb_plug_events_active(sw, false);
@@ -1617,7 +1616,7 @@ void tb_sw_set_unplugged(struct tb_switch *sw) 
	}

	sw->is_unplugged = true;

	for (i = 0; i <= sw->config.max_port_number; i++) {

		if (!tb_is_upstream_port(&sw->ports[i]) && sw->ports[i].remote)

		if (tb_port_has_remote(&sw->ports[i]))

			tb_sw_set_unplugged(sw->ports[i].remote->sw);

	}

}
@@ -1663,10 +1662,10 @@ int tb_switch_resume(struct tb_switch *sw) 
	/* check for surviving downstream switches */

	for (i = 1; i <= sw->config.max_port_number; i++) {

		struct tb_port *port = &sw->ports[i];

		if (tb_is_upstream_port(port))

			continue;

		if (!port->remote)



		if (!tb_port_has_remote(port))

			continue;



		if (tb_wait_for_port(port, true) <= 0

			|| tb_switch_resume(port->remote->sw)) {

			tb_port_warn(port,
@@ -1685,7 +1684,7 @@ void tb_switch_suspend(struct tb_switch *sw) 
		return;



	for (i = 1; i <= sw->config.max_port_number; i++) {

		if (!tb_is_upstream_port(&sw->ports[i]) && sw->ports[i].remote)

		if (tb_port_has_remote(&sw->ports[i]))

			tb_switch_suspend(sw->ports[i].remote->sw);

	}

drivers/thunderbolt/tb.c

+21 −9
Original line number Diff line number Diff line
@@ -47,7 +47,9 @@ static void tb_scan_switch(struct tb_switch *sw) 
 */

static void tb_scan_port(struct tb_port *port)

{

	struct tb_port *upstream_port;

	struct tb_switch *sw;



	if (tb_is_upstream_port(port))

		return;

	if (port->config.type != TB_TYPE_PORT)
@@ -80,8 +82,15 @@ static void tb_scan_port(struct tb_port *port) 
		return;

	}



	port->remote = tb_upstream_port(sw);

	tb_upstream_port(sw)->remote = port;

	/* Link the switches using both links if available */

	upstream_port = tb_upstream_port(sw);

	port->remote = upstream_port;

	upstream_port->remote = port;

	if (port->dual_link_port && upstream_port->dual_link_port) {

		port->dual_link_port->remote = upstream_port->dual_link_port;

		upstream_port->dual_link_port->remote = port->dual_link_port;

	}



	tb_scan_switch(sw);

}
@@ -111,13 +120,15 @@ static void tb_free_unplugged_children(struct tb_switch *sw) 
	int i;

	for (i = 1; i <= sw->config.max_port_number; i++) {

		struct tb_port *port = &sw->ports[i];

		if (tb_is_upstream_port(port))

			continue;

		if (!port->remote)



		if (!tb_port_has_remote(port))

			continue;



		if (port->remote->sw->is_unplugged) {

			tb_switch_remove(port->remote->sw);

			port->remote = NULL;

			if (port->dual_link_port)

				port->dual_link_port->remote = NULL;

		} else {

			tb_free_unplugged_children(port->remote->sw);

		}
@@ -273,18 +284,19 @@ static void tb_handle_hotplug(struct work_struct *work) 
	}

	port = &sw->ports[ev->port];

	if (tb_is_upstream_port(port)) {

		tb_warn(tb,

			"hotplug event for upstream port %llx:%x (unplug: %d)\n",

		tb_dbg(tb, "hotplug event for upstream port %llx:%x (unplug: %d)\n",

		       ev->route, ev->port, ev->unplug);

		goto put_sw;

	}

	if (ev->unplug) {

		if (port->remote) {

		if (tb_port_has_remote(port)) {

			tb_port_info(port, "unplugged\n");

			tb_sw_set_unplugged(port->remote->sw);

			tb_free_invalid_tunnels(tb);

			tb_switch_remove(port->remote->sw);

			port->remote = NULL;

			if (port->dual_link_port)

				port->dual_link_port->remote = NULL;

		} else {

			tb_port_info(port,

				     "got unplug event for disconnected port, ignoring\n");

drivers/thunderbolt/tb.h

+31 −5
Original line number Diff line number Diff line
@@ -270,6 +270,19 @@ static inline struct tb_port *tb_upstream_port(struct tb_switch *sw) 
	return &sw->ports[sw->config.upstream_port_number];

}



/**

 * tb_is_upstream_port() - Is the port upstream facing

 * @port: Port to check

 *

 * Returns true if @port is upstream facing port. In case of dual link

 * ports both return true.

 */

static inline bool tb_is_upstream_port(const struct tb_port *port)

{

	const struct tb_port *upstream_port = tb_upstream_port(port->sw);

	return port == upstream_port || port->dual_link_port == upstream_port;

}



static inline u64 tb_route(struct tb_switch *sw)

{

	return ((u64) sw->config.route_hi) << 32 | sw->config.route_lo;
@@ -285,6 +298,24 @@ static inline struct tb_port *tb_port_at(u64 route, struct tb_switch *sw) 
	return &sw->ports[port];

}



/**

 * tb_port_has_remote() - Does the port have switch connected downstream

 * @port: Port to check

 *

 * Returns true only when the port is primary port and has remote set.

 */

static inline bool tb_port_has_remote(const struct tb_port *port)

{

	if (tb_is_upstream_port(port))

		return false;

	if (!port->remote)

		return false;

	if (port->dual_link_port && port->link_nr)

		return false;



	return true;

}



static inline int tb_sw_read(struct tb_switch *sw, void *buffer,

			     enum tb_cfg_space space, u32 offset, u32 length)

{
@@ -489,11 +520,6 @@ static inline int tb_route_length(u64 route) 
	return (fls64(route) + TB_ROUTE_SHIFT - 1) / TB_ROUTE_SHIFT;

}



static inline bool tb_is_upstream_port(struct tb_port *port)

{

	return port == tb_upstream_port(port->sw);

}



/**

 * tb_downstream_route() - get route to downstream switch

 *

drivers/thunderbolt/xdomain.c

+1 −4
Original line number Diff line number Diff line
@@ -1293,9 +1293,6 @@ static struct tb_xdomain *switch_find_xdomain(struct tb_switch *sw, 
		struct tb_port *port = &sw->ports[i];

		struct tb_xdomain *xd;



		if (tb_is_upstream_port(port))

			continue;



		if (port->xdomain) {

			xd = port->xdomain;
@@ -1310,7 +1307,7 @@ static struct tb_xdomain *switch_find_xdomain(struct tb_switch *sw, 
				   lookup->route == xd->route) {

				return xd;

			}

		} else if (port->remote) {

		} else if (tb_port_has_remote(port)) {

			xd = switch_find_xdomain(port->remote->sw, lookup);

			if (xd)

				return xd;

CRA Git | Maintained and supported by SUSTech CRA and CCSE