Commit dfbca61a authored by Mark Rutland's avatar Mark Rutland Committed by Catalin Marinas
Browse files

arm64: hibernate: handle allocation failures 



In create_safe_exec_page(), we create a copy of the hibernate exit text,
along with some page tables to map this via TTBR0. We then install the
new tables in TTBR0.

In swsusp_arch_resume() we call create_safe_exec_page() before trying a
number of operations which may fail (e.g. copying the linear map page
tables). If these fail, we bail out of swsusp_arch_resume() and return
an error code, but leave TTBR0 as-is. Subsequently, the core hibernate
code will call free_basic_memory_bitmaps(), which will free all of the
memory allocations we made, including the page tables installed in
TTBR0.

Thus, we may have TTBR0 pointing at dangling freed memory for some
period of time. If the hibernate attempt was triggered by a user
requesting a hibernate test via the reboot syscall, we may return to
userspace with the clobbered TTBR0 value.

Avoid these issues by reorganising swsusp_arch_resume() such that we
have no failure paths after create_safe_exec_page(). We also add a check
that the zero page allocation succeeded, matching what we have for other
allocations.

Fixes: 82869ac5 ("arm64: kernel: Add support for hibernate/suspend-to-disk")
Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
Acked-by: default avatarJames Morse <james.morse@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: <stable@vger.kernel.org> # 4.7+
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 0194e760

arch/arm64/kernel/hibernate.c

+32 −27
Original line number Diff line number Diff line
@@ -404,6 +404,38 @@ int swsusp_arch_resume(void) 
	void __noreturn (*hibernate_exit)(phys_addr_t, phys_addr_t, void *,

					  void *, phys_addr_t, phys_addr_t);



	/*

	 * Restoring the memory image will overwrite the ttbr1 page tables.

	 * Create a second copy of just the linear map, and use this when

	 * restoring.

	 */

	tmp_pg_dir = (pgd_t *)get_safe_page(GFP_ATOMIC);

	if (!tmp_pg_dir) {

		pr_err("Failed to allocate memory for temporary page tables.");

		rc = -ENOMEM;

		goto out;

	}

	rc = copy_page_tables(tmp_pg_dir, PAGE_OFFSET, 0);

	if (rc)

		goto out;



	/*

	 * Since we only copied the linear map, we need to find restore_pblist's

	 * linear map address.

	 */

	lm_restore_pblist = LMADDR(restore_pblist);



	/*

	 * We need a zero page that is zero before & after resume in order to

	 * to break before make on the ttbr1 page tables.

	 */

	zero_page = (void *)get_safe_page(GFP_ATOMIC);

	if (!zero_page) {

		pr_err("Failed to allocate zero page.");

		rc = -ENOMEM;

		goto out;

	}



	/*

	 * Locate the exit code in the bottom-but-one page, so that *NULL

	 * still has disastrous affects.
@@ -429,27 +461,6 @@ int swsusp_arch_resume(void) 
	 */

	__flush_dcache_area(hibernate_exit, exit_size);



	/*

	 * Restoring the memory image will overwrite the ttbr1 page tables.

	 * Create a second copy of just the linear map, and use this when

	 * restoring.

	 */

	tmp_pg_dir = (pgd_t *)get_safe_page(GFP_ATOMIC);

	if (!tmp_pg_dir) {

		pr_err("Failed to allocate memory for temporary page tables.");

		rc = -ENOMEM;

		goto out;

	}

	rc = copy_page_tables(tmp_pg_dir, PAGE_OFFSET, 0);

	if (rc)

		goto out;



	/*

	 * Since we only copied the linear map, we need to find restore_pblist's

	 * linear map address.

	 */

	lm_restore_pblist = LMADDR(restore_pblist);



	/*

	 * KASLR will cause the el2 vectors to be in a different location in

	 * the resumed kernel. Load hibernate's temporary copy into el2.
@@ -464,12 +475,6 @@ int swsusp_arch_resume(void) 
		__hyp_set_vectors(el2_vectors);

	}



	/*

	 * We need a zero page that is zero before & after resume in order to

	 * to break before make on the ttbr1 page tables.

	 */

	zero_page = (void *)get_safe_page(GFP_ATOMIC);



	hibernate_exit(virt_to_phys(tmp_pg_dir), resume_hdr.ttbr1_el1,

		       resume_hdr.reenter_kernel, lm_restore_pblist,

		       resume_hdr.__hyp_stub_vectors, virt_to_phys(zero_page));

CRA Git | Maintained and supported by SUSTech CRA and CCSE