Commit dfb06cba authored Sep 05, 2018 by Dave Jiang Committed by Dan Williams Sep 12, 2018

uaccess: Fix is_source param for check_copy_size() in copy_to_iter_mcsafe()



copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
to check_copy_size(). This is different than what copy_to_iter() does.
Also, the addr parameter passed to check_copy_size() is the source so
therefore we should be passing in "true" instead.

Fixes: 8780356e ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
Cc: <stable@vger.kernel.org>
Reported-by: Fan Du <fan.du@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Reported-by: Wenwei Tao <wenwei.tww@alibaba-inc.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent b90ca5cc

include/linux/uio.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -172,7 +172,7 @@ size_t copy_from_iter_flushcache(void addr, size_t bytes, struct iov_iter i)
		static __always_inline __must_check
		size_t copy_to_iter_mcsafe(void addr, size_t bytes, struct iov_iter i)
		{
		if (unlikely(!check_copy_size(addr, bytes, false)))
		if (unlikely(!check_copy_size(addr, bytes, true)))
		return 0;
		else
		return _copy_to_iter_mcsafe(addr, bytes, i);

Admin message