ubifs: Make xattr structures static (dfaf8d2a) · Commits · 戴 / test

Fix sparse warnings from the use of "struct xattr_handler" structures that are not exported by making them static. Fixes the following sparse warnings: /fs/ubifs/xattr.c:595:28: warning: symbol 'ubifs_user_xattr_handler' was not declared. Should it be static? /fs/ubifs/xattr.c:601:28: warning: symbol 'ubifs_trusted_xattr_handler' was not declared. Should it be static? /fs/ubifs/xattr.c:607:28: warning: symbol 'ubifs_security_xattr_handler' was not declared. Should it be static? Signed-off-by:

Ben Dooks <ben.dooks@codethink.co.uk> Signed-off-by:

Richard Weinberger <richard@nod.at>

fs/ubifs/xattr.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -592,19 +592,19 @@ static int ubifs_xattr_set(const struct xattr_handler *handler,
		return __ubifs_removexattr(inode, name);
		}

		const struct xattr_handler ubifs_user_xattr_handler = {
		static const struct xattr_handler ubifs_user_xattr_handler = {
		.prefix = XATTR_USER_PREFIX,
		.get = ubifs_xattr_get,
		.set = ubifs_xattr_set,
		};

		const struct xattr_handler ubifs_trusted_xattr_handler = {
		static const struct xattr_handler ubifs_trusted_xattr_handler = {
		.prefix = XATTR_TRUSTED_PREFIX,
		.get = ubifs_xattr_get,
		.set = ubifs_xattr_set,
		};

		const struct xattr_handler ubifs_security_xattr_handler = {
		static const struct xattr_handler ubifs_security_xattr_handler = {
		.prefix = XATTR_SECURITY_PREFIX,
		.get = ubifs_xattr_get,
		.set = ubifs_xattr_set,

Admin message