scsi: lpfc: Fix: Rework setting of fdmi symbolic node name registration

lpfc_vport_symbolic_node_name(struct lpfc_vport *vport, char *symbol,

	size_t size)

{

	char fwrev[FW_REV_STR_SIZE];

	int n;

	char fwrev[FW_REV_STR_SIZE] = {0};

	char tmp[MAXHOSTNAMELEN] = {0};

	lpfc_decode_firmware_rev(vport->phba, fwrev, 0);

	memset(symbol, 0, size);

	n = scnprintf(symbol, size, "Emulex %s", vport->phba->ModelName);

	if (size < n)

		return n;

	scnprintf(tmp, sizeof(tmp), "Emulex %s", vport->phba->ModelName);

	if (strlcat(symbol, tmp, size) >= size)

		goto buffer_done;

	n += scnprintf(symbol + n, size - n, " FV%s", fwrev);

	if (size < n)

		return n;

	lpfc_decode_firmware_rev(vport->phba, fwrev, 0);

	scnprintf(tmp, sizeof(tmp), " FV%s", fwrev);

	if (strlcat(symbol, tmp, size) >= size)

		goto buffer_done;

	n += scnprintf(symbol + n, size - n, " DV%s.",

		      lpfc_release_version);

	if (size < n)

		return n;

	scnprintf(tmp, sizeof(tmp), " DV%s", lpfc_release_version);

	if (strlcat(symbol, tmp, size) >= size)

		goto buffer_done;

	n += scnprintf(symbol + n, size - n, " HN:%s.",

		      init_utsname()->nodename);

	if (size < n)

		return n;

	scnprintf(tmp, sizeof(tmp), " HN:%s", init_utsname()->nodename);

	if (strlcat(symbol, tmp, size) >= size)

		goto buffer_done;

	/* Note :- OS name is "Linux" */

	n += scnprintf(symbol + n, size - n, " OS:%s",

		      init_utsname()->sysname);

	return n;

	scnprintf(tmp, sizeof(tmp), " OS:%s", init_utsname()->sysname);

	strlcat(symbol, tmp, size);

buffer_done:

	return strnlen(symbol, size);

}

static uint32_t