Commit df823b02 authored by Jamal Hadi Salim's avatar Jamal Hadi Salim Committed by David S. Miller
Browse files

net sched actions: Use proper root attribute table for actions 



Bug fix for an issue which has been around for about a decade.
We got away with it because the enumeration was larger than needed.

Fixes: 7ba699c6 ("[NET_SCHED]: Convert actions from rtnetlink to new netlink API")
Suggested-by: default avatarJiri Pirko <jiri@mellanox.com>
Reviewed-by: default avatarSimon Horman <simon.horman@netronome.com>
Signed-off-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 64c83d83

net/sched/act_api.c

+2 −2
Original line number Diff line number Diff line
@@ -1072,7 +1072,7 @@ static int tc_ctl_action(struct sk_buff *skb, struct nlmsghdr *n, 
			 struct netlink_ext_ack *extack)

{

	struct net *net = sock_net(skb->sk);

	struct nlattr *tca[TCA_ACT_MAX + 1];

	struct nlattr *tca[TCAA_MAX + 1];

	u32 portid = skb ? NETLINK_CB(skb).portid : 0;

	int ret = 0, ovr = 0;
@@ -1080,7 +1080,7 @@ static int tc_ctl_action(struct sk_buff *skb, struct nlmsghdr *n, 
	    !netlink_capable(skb, CAP_NET_ADMIN))

		return -EPERM;



	ret = nlmsg_parse(n, sizeof(struct tcamsg), tca, TCA_ACT_MAX, NULL,

	ret = nlmsg_parse(n, sizeof(struct tcamsg), tca, TCAA_MAX, NULL,

			  extack);

	if (ret < 0)

		return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE