Commit df807a19 authored by Colin Ian King's avatar Colin Ian King Committed by Herbert Xu
Browse files

chcr: ensure cntrl is initialized to fix bit-wise or'ing of garabage data



In the case where skb->ip_summed != CHECKSUM_PARTIAL then cntrl contains
garbage value and this is possibly being bit-wise or'd and stored into
cpl->ctrl1.  Fix this by initializing cntrl to zero.

Cleans up clang warning:
drivers/crypto/chelsio/chcr_ipsec.c:374:9: warning: The left expression
of the compound assignment is an uninitialized value. The computed value
will also be garbage

Fixes: 6dad4e8a ("chcr: Add support for Inline IPSec")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 267469ea
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -350,7 +350,7 @@ inline void *copy_cpltx_pktxt(struct sk_buff *skb,
	struct port_info *pi;
	struct sge_eth_txq *q;
	struct cpl_tx_pkt_core *cpl;
	u64 cntrl;
	u64 cntrl = 0;
	u32 ctrl0, qidx;

	pi = netdev_priv(dev);