mmc: omap: Initialize dma_slave_config to avoid random data in it's fields (df804d5e) · Commits · 戴 / test

It is wrong to use uninitialized dma_slave_config and configure only certain fields as the DMAengine driver might look at non initialized (random data) fields and tries to interpret it. Signed-off-by:

Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by:

Ulf Hansson <ulf.hansson@linaro.org>

drivers/mmc/host/omap.c

+10 −8

Original line number	Diff line number	Diff line
		@@ -1016,14 +1016,16 @@ mmc_omap_prepare_data(struct mmc_omap_host host, struct mmc_request req)

		/* Only reconfigure if we have a different burst size */
		if (*bp != burst) {
		struct dma_slave_config cfg;

		cfg.src_addr = host->phys_base + OMAP_MMC_REG(host, DATA);
		cfg.dst_addr = host->phys_base + OMAP_MMC_REG(host, DATA);
		cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
		cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
		cfg.src_maxburst = burst;
		cfg.dst_maxburst = burst;
		struct dma_slave_config cfg = {
		.src_addr = host->phys_base +
		OMAP_MMC_REG(host, DATA),
		.dst_addr = host->phys_base +
		OMAP_MMC_REG(host, DATA),
		.src_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES,
		.dst_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES,
		.src_maxburst = burst,
		.dst_maxburst = burst,
		};

		if (dmaengine_slave_config(c, &cfg))
		goto use_pio;

Admin message