Commit df7c1ca2 authored by Geoff Levand's avatar Geoff Levand
Browse files

usb: Fix PS3 EHCI suspend 



The EHCI USB controller of the Cell Super Companion Chip used in the PS3
will stop the root hub after all root hub ports are suspended.  When in
this condition the ehci-hcd handshake routine will return -ETIMEDOUT and
the USB runtime suspend sequence will fail.  The STS_HLT bit will not be
set, so inspection of the frame index is used to test for the condition.

Add a new routine handshake_for_broken_root_hub() that is called after
an unsuccessful -ETIMEDOUT handshake.  On PS3 handshake_for_broken_root_hub()
will test for the condition, and if found will return success to allow the
USB suspend to complete.  For all other platforms
handshake_for_broken_root_hub() will return -ETIMEDOUT

Signed-off-by: default avatarGeoff Levand <geoff@infradead.org>
Signed-off-by: default avatarAlan Stern <stern@rowland.harvard.edu>
parent 9187bef2

drivers/usb/host/ehci-hcd.c

+50 −0
Original line number Diff line number Diff line
@@ -48,6 +48,10 @@ 
#include <asm/system.h>

#include <asm/unaligned.h>



#if defined(CONFIG_PPC_PS3)

#include <asm/firmware.h>

#endif



/*-------------------------------------------------------------------------*/



/*
@@ -230,12 +234,58 @@ static int ehci_halt (struct ehci_hcd *ehci) 
			  STS_HALT, STS_HALT, 16 * 125);

}



#if defined(CONFIG_USB_SUSPEND) && defined(CONFIG_PPC_PS3)



/*

 * The EHCI controller of the Cell Super Companion Chip used in the

 * PS3 will stop the root hub after all root hub ports are suspended.

 * When in this condition handshake will return -ETIMEDOUT.  The

 * STS_HLT bit will not be set, so inspection of the frame index is

 * used here to test for the condition.  If the condition is found

 * return success to allow the USB suspend to complete.

 */



static int handshake_for_broken_root_hub(struct ehci_hcd *ehci,

					 void __iomem *ptr, u32 mask, u32 done,

					 int usec)

{

	unsigned int old_index;

	int error;



	if (!firmware_has_feature(FW_FEATURE_PS3_LV1))

		return -ETIMEDOUT;



	old_index = ehci_read_frame_index(ehci);



	error = handshake(ehci, ptr, mask, done, usec);



	if (error == -ETIMEDOUT && ehci_read_frame_index(ehci) == old_index)

		return 0;



	return error;

}



#else



static int handshake_for_broken_root_hub(struct ehci_hcd *ehci,

					 void __iomem *ptr, u32 mask, u32 done,

					 int usec)

{

	return -ETIMEDOUT;

}



#endif



static int handshake_on_error_set_halt(struct ehci_hcd *ehci, void __iomem *ptr,

				       u32 mask, u32 done, int usec)

{

	int error;



	error = handshake(ehci, ptr, mask, done, usec);

	if (error == -ETIMEDOUT)

		error = handshake_for_broken_root_hub(ehci, ptr, mask, done,

						      usec);



	if (error) {

		ehci_halt(ehci);

		ehci->rh_state = EHCI_RH_HALTED;

CRA Git | Maintained and supported by SUSTech CRA and CCSE