Commit df62db5b authored Apr 19, 2017 by Steven Rostedt (VMware)

tracing: Allocate the snapshot buffer before enabling probe

Currently the snapshot trigger enables the probe and then allocates the
snapshot. If the probe triggers before the allocation, it could cause the
snapshot to fail and turn tracing off. It's best to allocate the snapshot
buffer first, and then enable the trigger. If something goes wrong in the
enabling of the trigger, the snapshot buffer is still allocated, but it can
also be freed by the user by writting zero into the snapshot buffer file.

Also add a check of the return status of alloc_snapshot().

Cc: stable@vger.kernel.org
Fixes: 77fd5c15 ("tracing: Add snapshot trigger to function probes")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent 9ed19c76

kernel/trace/trace.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -6733,11 +6733,13 @@ ftrace_trace_snapshot_callback(struct ftrace_hash *hash,
		return ret;

		out_reg:
		ret = register_ftrace_function_probe(glob, ops, count);
		ret = alloc_snapshot(&global_trace);
		if (ret < 0)
		goto out;

		if (ret >= 0)
		alloc_snapshot(&global_trace);
		ret = register_ftrace_function_probe(glob, ops, count);

		out:
		return ret < 0 ? ret : 0;
		}

Admin message