Commit df59c0ad authored Jun 10, 2009 by Alexey Zaytsev Committed by James Bottomley Jun 15, 2009

[SCSI] compat: don't perform unneeded copy in sg_io code



The members from 'status' in struct sg_io_hdr to the last are used to
transfer information from kernel to user space.  The values that user
space sets are just ignored.

Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
Acked-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent dc577d55

fs/compat_ioctl.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -788,12 +788,6 @@ static int sg_ioctl_trans(unsigned int fd, unsigned int cmd, unsigned long arg)
		if (put_user(compat_ptr(data), &sgio->usr_ptr))
		return -EFAULT;

		if (copy_in_user(&sgio->status, &sgio32->status,
		(4 * sizeof(unsigned char)) +
		(2 * sizeof(unsigned short)) +
		(3 * sizeof(int))))
		return -EFAULT;

		err = sys_ioctl(fd, cmd, (unsigned long) sgio);

		if (err >= 0) {

Admin message