Commit df568d8e authored by David S. Miller's avatar David S. Miller
Browse files

scsi: Use 'depends' with LIBFC instead of 'select'. 



LIBFC depends upon SCSI_FC_ATTRS and select's CRC32C.

The only alternative would be to 'select' CRC32C and all of
SCSI_FC_ATTRS direct and indirect dependencies in the Kconfig section
for every LIBFCOE user which makes little sense.

Subsequently, use 'depends' instead of 'select' for LIBFCOE too.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent afbe7af1

drivers/scsi/Kconfig

+3 −3
Original line number Diff line number Diff line
@@ -592,21 +592,21 @@ config LIBFC 


config LIBFCOE

	tristate "LibFCoE module"

	select LIBFC

	depends on LIBFC

	---help---

	  Library for Fibre Channel over Ethernet module



config FCOE

	tristate "FCoE module"

	depends on PCI

	select LIBFCOE

	depends on LIBFCOE

	---help---

	  Fibre Channel over Ethernet module



config FCOE_FNIC

	tristate "Cisco FNIC Driver"

	depends on PCI && X86

	select LIBFCOE

	depends on LIBFCOE

	help

	  This is support for the Cisco PCI-Express FCoE HBA.

drivers/scsi/bnx2fc/Kconfig

+2 −2
Original line number Diff line number Diff line
@@ -2,11 +2,11 @@ config SCSI_BNX2X_FCOE 
	tristate "QLogic NetXtreme II FCoE support"

	depends on PCI

	depends on (IPV6 || IPV6=n)

	depends on LIBFC

	depends on LIBFCOE

	select NETDEVICES

	select ETHERNET

	select NET_VENDOR_BROADCOM

	select LIBFC

	select LIBFCOE

	select CNIC

	---help---

	This driver supports FCoE offload for the QLogic NetXtreme II

drivers/scsi/qla2xxx/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ config SCSI_QLA_FC 
config TCM_QLA2XXX

	tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"

	depends on SCSI_QLA_FC && TARGET_CORE

	select LIBFC

	depends on LIBFC

	select BTREE

	default n

	---help---

CRA Git | Maintained and supported by SUSTech CRA and CCSE