davinci: gpio irq enable tweaks (df4aab46) · Commits · 戴 / test

Fix two IRQ triggering bugs affecting GPIO IRQs: - Make sure enabling with IRQ_TYPE_NONE ("default, unspecified") isn't a NOP ... default to both edges, at least one must work. - As noted by Kevin Hilman, setting the irq trigger type for a banked gpio interrupt shouldn't enable irqs that are disabled. Since GPIO IRQs haven't been used much yet, it's not clear these bugs could have affected anything. The few current users don't seem to have been obviously suffering from these issues. Signed-off-by:

David Brownell <dbrownell@users.sourceforge.net> Signed-off-by:

Kevin Hilman <khilman@deeprootsystems.com>

arch/arm/mach-davinci/gpio.c

+14 −6

Original line number	Diff line number	Diff line
		@@ -187,10 +187,15 @@ static void gpio_irq_enable(unsigned irq)
		{
		struct gpio_controller *__iomem g = get_irq_chip_data(irq);
		u32 mask = __gpio_mask(irq_to_gpio(irq));
		unsigned status = irq_desc[irq].status;

		if (irq_desc[irq].status & IRQ_TYPE_EDGE_FALLING)
		status &= IRQ_TYPE_EDGE_FALLING \| IRQ_TYPE_EDGE_RISING;
		if (!status)
		status = IRQ_TYPE_EDGE_FALLING \| IRQ_TYPE_EDGE_RISING;

		if (status & IRQ_TYPE_EDGE_FALLING)
		__raw_writel(mask, &g->set_falling);
		if (irq_desc[irq].status & IRQ_TYPE_EDGE_RISING)
		if (status & IRQ_TYPE_EDGE_RISING)
		__raw_writel(mask, &g->set_rising);
		}

		@@ -205,10 +210,13 @@ static int gpio_irq_type(unsigned irq, unsigned trigger)
		irq_desc[irq].status &= ~IRQ_TYPE_SENSE_MASK;
		irq_desc[irq].status \|= trigger;

		/* don't enable the IRQ if it's currently disabled */
		if (irq_desc[irq].depth == 0) {
		__raw_writel(mask, (trigger & IRQ_TYPE_EDGE_FALLING)
		? &g->set_falling : &g->clr_falling);
		__raw_writel(mask, (trigger & IRQ_TYPE_EDGE_RISING)
		? &g->set_rising : &g->clr_rising);
		}
		return 0;
		}

Admin message