Commit df4368a1 authored Jun 23, 2011 by Dave Chinner Committed by Alex Elder Jun 23, 2011

xfs: clear XFS_IDIRTY_RELEASE on truncate down



When an inode is truncated down, speculative preallocation is
removed from the inode. This should also reset the state bits for
controlling whether preallocation is subsequently removed when the
file is next closed. The flag is not being cleared, so repeated
operations on a file that first involve a truncate (e.g. multiple
repeated dd invocations on a file) give different file layouts for
the second and subsequent invocations.

Fix this by clearing the XFS_IDIRTY_RELEASE state bit when the
XFS_ITRUNCATED bit is detected in xfs_release() and hence ensure
that speculative delalloc is removed on files that have been
truncated down.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

parent 778e24bb

fs/xfs/xfs_vnodeops.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -960,9 +960,12 @@ xfs_release(
		* be exposed to that problem.
		*/
		truncated = xfs_iflags_test_and_clear(ip, XFS_ITRUNCATED);
		if (truncated && VN_DIRTY(VFS_I(ip)) && ip->i_delayed_blks > 0)
		if (truncated) {
		xfs_iflags_clear(ip, XFS_IDIRTY_RELEASE);
		if (VN_DIRTY(VFS_I(ip)) && ip->i_delayed_blks > 0)
		xfs_flush_pages(ip, 0, -1, XBF_ASYNC, FI_NONE);
		}
		}

		if (ip->i_d.di_nlink == 0)
		return 0;

Admin message